fix: async implementation #179

matthewkeil · 2024-04-20T16:21:25Z

There was a hard import of @chainsafe/blst at the head of functional.ts that was causing issues with tree shaking.

Removed implementation specific code from isomorphic files
Made async versions of the functions on the respective class interfaces
Widened types to allow both serialized and deserialized objects as function arguments
Moved herumi specific implementation details into the herumi classes
Moved blst-native specific implementation details into the blst-native classes
Re-implemented functional.ts to take advantage of the above and simplify the isomorphic code
Remove webpack config that was added because of the unnoticed import of blst to get the web tests to work
Minor version bump because some types on public API were widened. Non-breaking though and also not a patch methinks

…ethods

…behavior

src/blst-native/publicKey.ts

src/blst-native/signature.ts

src/functional.ts

twoeths · 2024-04-22T03:19:22Z

src/functional.ts

@@ -75,27 +57,12 @@ export function functionalInterfaceFactory({
   */
  function verifyAggregate(publicKeys: PublicKeyArg[], message: Uint8Array, signature: SignatureArg): boolean {
    try {
-      validateBytes(message, "message");
-
-      const pks: PublicKey[] = [];


is it not necessary to validateByutes for public keys anymore?

I found it's implemented for PublicKey.convertToPublicKeyType of herumi but not for blst-native

Yep! Exactly. This was the optimization I made. For serialized objects we were parsing the bytes both here in JS land and in the native code as well. I removed this so that the herumi specific parse is off the main code path and only gets executed for herumi.

src/herumi/signature.ts

src/functional.ts

twoeths

the change makes sense, dropped some comments

matthewkeil added 6 commits April 19, 2024 21:19

feat: move all async to respective Signature class

7a3cffc

feat: update blst-native classes for async implementation

0529370

feat: update herumi classes to move herumi specific code into class m…

7afcd19

…ethods

feat: fix functional.ts to make isomorphic again

f228072

fix: remove webpack config fixes triggered by unseen blst import

55681f0

feat: widen types and add comments for methods to highlight throwing …

321100d

…behavior

matthewkeil requested a review from a team as a code owner April 20, 2024 16:21

matthewkeil added 2 commits April 20, 2024 23:26

fix: typo

7f336f4

chore: bump minor version

977f708

matthewkeil mentioned this pull request Apr 21, 2024

feat: switch bls to napi rebuild ChainSafe/lodestar#6616

Merged