feat: add compression support to metrics and RPC servers #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
commented
Oct 16, 2024
src/rpc/mod.rs
Outdated
| @@ -485,6 +486,13 @@ where | |||
| svc_builder, | |||
| keystore, | |||
| } = per_conn.clone(); | |||
| let http_middleware = tower::ServiceBuilder::new() | |||
| // This does not compile yet, a fix has been made in https://github.com/paritytech/jsonrpsee/pull/1475 | |||
| // .layer(CompressionLayer::new()) | |||
There was a problem hiding this comment.
I can uncomment this line in a subsequent PR once a new version of jsonrpsee is released.
hanabi1224
requested review from
lemmih and
elmattic
and removed request for
a team
hanabi1224
commented
Oct 16, 2024
| @@ -184,7 +184,8 @@ tokio = { version = "1", features = ['full'] } | |||
| tokio-stream = { version = "0.1", features = ["fs", "io-util"] } | |||
| tokio-util = { version = "0.7", features = ["compat", "io-util"] } | |||
| toml = "0.8" | |||
| tower = { version = "0.5", features = ["full"] } | |||
| tower = { version = "0.4", features = ["util"] } | |||
There was a problem hiding this comment.
downgrade tower to align with jsonrpsee
There was a problem hiding this comment.
@hanabi1224 Should we put a comment here so that people avoid updating (and a similar one in the jsonrpsee so that people update it when needed).
There was a problem hiding this comment.
@LesnyRumcajs Now It does not compile if tower and jsonrpsee versions don't match
There was a problem hiding this comment.
@LesnyRumcajs Now It does not compile if tower and jsonrpsee versions don't match
elmattic
approved these changes
Oct 16, 2024
lemmih
approved these changes
Oct 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Part of #4903
Changes introduced in this pull request:
blocked on fix(server): make tower::Service impl generic over HttpBody paritytech/jsonrpsee#1475)Authorizationrequest header as sensitive so it doesn't show in logsjsonrpseeReference issue to close (if applicable)
Closes #4903
Other information and links
Change checklist