-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prospective-parachains): Implement HandleIntroduceSecondedCandidate
#4350
base: eclesio/fragment-chain-impl
Are you sure you want to change the base?
feat(prospective-parachains): Implement HandleIntroduceSecondedCandidate
#4350
Conversation
|
|
HandleIntroduceSecondedCandidate
should wait the merge of branch of #4337 |
…uce_seconded_candidate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small chores about logging format and public methods
dot/parachain/prospective-parachains/prospective_parachains_test.go
Outdated
Show resolved
Hide resolved
dot/parachain/prospective-parachains/prospective_parachains_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Eclésio Junior <[email protected]>
Co-authored-by: Eclésio Junior <[email protected]>
Co-authored-by: Eclésio Junior <[email protected]>
Co-authored-by: Eclésio Junior <[email protected]>
Co-authored-by: Eclésio Junior <[email protected]>
Co-authored-by: Eclésio Junior <[email protected]>
Co-authored-by: Eclésio Junior <[email protected]>
…st.go Co-authored-by: Eclésio Junior <[email protected]>
…st.go Co-authored-by: Eclésio Junior <[email protected]>
…uce_seconded_candidate
Currently waiting for #4337 |
Changes
This PR introduces the
HandleIntroduceSecondedCandidate
func toprospectiveparachains
package.Notes:
currently there's no implementation for ImplicitView, reference is:
polkadot-sdk reference
Tests
go test -timeout 30s github.com/ChainSafe/gossamer/dot/parachain/prospective-parachains
Issues
closes #4308