feat(prospective-parachains): implements GetBackableCandidates
#4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added: Candidate Entry - (inclusion_emulator): Added ProspectiveCandidate, Modification error and Fragment Validity error
…elDDHM/gossamer into feature/add_get_backable_candidates
DanielDDHM
changed the title
|
@haikoschol @EclesioMeloJunior @P1sar a small review please. |
DanielDDHM
changed the title
GetBackableCandidates
haikoschol
requested changes
Dec 16, 2024
dot/parachain/prospective-parachains/prospective_parachains_test.go
Outdated
Show resolved
Hide resolved
DanielDDHM
changed the base branch from
eclesio/fragment-chain-impl
to
feat/parachain
EclesioMeloJunior
approved these changes
Jan 8, 2025
dot/parachain/prospective-parachains/prospective_parachains_test.go
Outdated
Show resolved
Hide resolved
haikoschol
requested changes
Jan 10, 2025
There was a problem hiding this comment.
@DanielDDHM TestGetBackableCandidates/candidates_found is failing in CI and when I run it locally.
@haikoschol could you take a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
implements GetBackableCandidates
Tests
Unit Tests: Core logic is tested in isolation using testify for assertions
go test -tags integration github.com/ChainSafe/gossamerIssues
GetBackableCandidatessignal #4310