Clean up Dockerfile for baremetal and ECS deployments #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Datadog vestiges - Remove running "gossamer init" during Docker build - Use the same entrypoint as the main Dockerfile to ease deployment
|
@Aminechakr as far as I can tell, |
P1sar
approved these changes
Dec 10, 2024
DanielDDHM
approved these changes
Dec 10, 2024
Yes, the mentioned workflow can be removed. |
Aminechakr
reviewed
Dec 12, 2024
Aminechakr
reviewed
Dec 12, 2024
👏 👏 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Apart from minor cleanups, this change uses the same
ENTRYPOINTas the mainDockerfile. The CLI flags passed to the container should be controlled by the deployment automation, not hard-coded in the Docker file.Tests