-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): implement ParachainHost_para_backing_state
runtime call
#4420
Merged
EclesioMeloJunior
merged 16 commits into
feat/parachain
from
eclesio/backing_state_runtime_call
Jan 6, 2025
Merged
feat(runtime): implement ParachainHost_para_backing_state
runtime call
#4420
EclesioMeloJunior
merged 16 commits into
feat/parachain
from
eclesio/backing_state_runtime_call
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EclesioMeloJunior
requested review from
jimjbrettj and
timwu20
as code owners
December 17, 2024 18:47
haikoschol
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some nits, good to merge as is
timwu20
reviewed
Dec 18, 2024
jimjbrettj
reviewed
Dec 18, 2024
jimjbrettj
reviewed
Dec 18, 2024
jimjbrettj
reviewed
Dec 18, 2024
timwu20
approved these changes
Dec 18, 2024
jimjbrettj
reviewed
Dec 18, 2024
jimjbrettj
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just some minor feedback
…Safe/gossamer into eclesio/backing_state_runtime_call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces a new runtime call function
ParachainHost_para_backing_state
which retrieves informations about the current backing state for a single parachain, these informations contains the currentConstraints
, which are used byProspective Parachains
to validate incoming candidates, alsoPendingAvailabilityCandidates
which are candidates backed on-chain that is waiting the availability step, they are also used byProspective Parachains
in order to select possible next candidates.Added to
parachaintypes
:Constraints
BackingState
CandidateDescriptorV2
Used the most up to date runtime available
Changed
wazero/Instance
to not hold an instance of the runtime, that is not needed once we bootstrap the runtime from a cached compiled module, also this field was not being used.Tests
go test -timeout 10m -run ^TestInstance_ParachainHostParaBackingState$ github.com/ChainSafe/gossamer/lib/runtime/wazero
Issues
ParachainHost_para_backing_state
runtime call #4416