-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup the React Components project #60
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very unfamiliar with this type of project, so I've just added a few basic comments. What can I do to help document this project?
Co-authored-by: Dan Forbes <[email protected]>
Thanks Dan; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your effort on this PR, but I can’t accept it in its current state. I would suggest to recreate your branch from main
because this PR includes commits that are already merged.
Also, I noticed modifications to files in circle-demo-webapp
and web3-circle-sdk
, as well as additional files shown in the screenshot below. Are they related to the setup of a new package? If not, could you clean this up and focus on providing a minimal package that exports a single component for publishing?
As a reference, you can copy one of the components from the demo app and test it manually end-to-end to ensure it works. Let me know if you need any help!
Hey @Muhammad-Altabba, I’ve improved my message, and I’m sorry for how the initial version came across. Let me know if you need any help! |
No issues, many thanks Kris, However, I will create separate MRs for each point to simplify the review. So we can review and discuss them separately. And I will start proposing the MRs that will affect the whole repo and its packages first. |
[UPDATED]
This MR s basically integrating the template https://github.com/IgnacioNMiranda/vite-component-library-template into this repo.
The some other files and folders are modified with very tiny stuff as I activated Husky and eslint to raise the code quality as Husky and eslint check was in the template and so I applied it to the whole project.
As a follow up to this MR the React components could be moved to the new project.