Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the React Components project #60

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Muhammad-Altabba
Copy link
Member

@Muhammad-Altabba Muhammad-Altabba commented Dec 9, 2024

[UPDATED]
This MR s basically integrating the template https://github.com/IgnacioNMiranda/vite-component-library-template into this repo.
The some other files and folders are modified with very tiny stuff as I activated Husky and eslint to raise the code quality as Husky and eslint check was in the template and so I applied it to the whole project.

  • adding the template https://github.com/IgnacioNMiranda/vite-component-library-template
  • configure husky on the root folder to run eslint before commit.
  • tiny lint fixing
  • unifying some library versions like the typescript and eslint version is now unified and upated at all projects.
  • yarn as the Package Manager is updated from 1.22.22 to 4.5.3.

As a follow up to this MR the React components could be moved to the new project.

@Muhammad-Altabba Muhammad-Altabba linked an issue Dec 9, 2024 that may be closed by this pull request
@Muhammad-Altabba Muhammad-Altabba changed the title setup the React Components project [DRAFT] setup the React Components project Dec 10, 2024
@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review December 11, 2024 15:05
@Muhammad-Altabba Muhammad-Altabba changed the title [DRAFT] setup the React Components project Setup the React Components project Dec 11, 2024
@Muhammad-Altabba Muhammad-Altabba requested review from krzysu, avkos and danforbes and removed request for krzysu and avkos December 11, 2024 20:55
Copy link
Contributor

@danforbes danforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very unfamiliar with this type of project, so I've just added a few basic comments. What can I do to help document this project?

packages/circle-react-components/.nvmrc Outdated Show resolved Hide resolved
packages/circle-react-components/README.md Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@Muhammad-Altabba
Copy link
Member Author

Muhammad-Altabba commented Dec 11, 2024

I'm very unfamiliar with this type of project, so I've just added a few basic comments. What can I do to help document this project?

Thanks Dan;
I think the documentation needs to come once the React Components are moved here.
I addressed all your comments. Feel free to add more if you will find.

Copy link
Contributor

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your effort on this PR, but I can’t accept it in its current state. I would suggest to recreate your branch from main because this PR includes commits that are already merged.

Also, I noticed modifications to files in circle-demo-webapp and web3-circle-sdk, as well as additional files shown in the screenshot below. Are they related to the setup of a new package? If not, could you clean this up and focus on providing a minimal package that exports a single component for publishing?

As a reference, you can copy one of the components from the demo app and test it manually end-to-end to ensure it works. Let me know if you need any help!

Screenshot 2024-12-12 at 09 41 47

@krzysu
Copy link
Contributor

krzysu commented Dec 17, 2024

Hey @Muhammad-Altabba, I’ve improved my message, and I’m sorry for how the initial version came across. Let me know if you need any help!

@Muhammad-Altabba
Copy link
Member Author

No issues, many thanks Kris,
Sorry that, the MR contains lots of changes altogether because of the time limit. And there was also no description depending on the early verbal communication. But now I edited the description to have clarity.

However, I will create separate MRs for each point to simplify the review. So we can review and discuss them separately. And I will start proposing the MRs that will affect the whole repo and its packages first.

@Muhammad-Altabba Muhammad-Altabba marked this pull request as draft December 19, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Components Project Setup
4 participants