Feature/ctek pypi #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaroDemergian
approved these changes
Jun 12, 2024
NotCosyMax
reviewed
Jun 13, 2024
| import voluptuous as vol | ||
|
|
||
| from homeassistant.config_entries import ConfigFlow, ConfigFlowResult | ||
| from homeassistant.const import CONF_URL | ||
|
|
||
| from .api import fetch_mac, get_ip | ||
| from .const import DOMAIN | ||
|
|
||
| API_DEFAULT = "http://ctek-ng-air.local/meter/" |
| import voluptuous as vol | ||
|
|
||
| from homeassistant.config_entries import ConfigFlow, ConfigFlowResult | ||
| from homeassistant.const import CONF_URL | ||
|
|
||
| from .api import fetch_mac, get_ip | ||
| from .const import DOMAIN | ||
|
|
||
| API_DEFAULT = "http://ctek-ng-air.local/meter/" |
There was a problem hiding this comment.
Not here, but below. Conflig flow do not have a reason to use the API url any more?
NotCosyMax
reviewed
Jun 14, 2024
| @@ -149,23 +149,23 @@ def __init__( | |||
| def native_value(self) -> str | None: | |||
| """Return the state of the sensor.""" | |||
| data = self.coordinator.data | |||
| if data is None: | |||
| if data is None or isinstance(data, dict): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: