Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to use https instead of git #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carsondarling
Copy link

Some environments (e.g. CircleCI) have an issue with cloning from NPM dependencies spec'd with a git:// URL. This PR switches to an HTTPS-based URL instead.

Reference: https://support.circleci.com/hc/en-us/articles/360009699913-Can-t-read-from-remote-git-repository-during-npm-install

This PR is published as @carsondarling/[email protected]

@jenskuhrjorgensen
Copy link

Hi @CharlesMangwa

I'm also stuck with this (because I use the Storybook addon ondevice-notes) which requires me to either install git on my CI (which would make me a sad panda), or getting this package updated.

I can see that there hasn't been much (any?) activity from you on this repo since your last release back in 2018. Is this repo still actively maintained?

Best regards
Jens

@jenskuhrjorgensen
Copy link

Update: I can see that the package.json has actually been updated with this, but has not been released yet. I've created another issue requesting a new release.

@calebgregory
Copy link

@CharlesMangwa - bump: https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git. as we enter the brownout phase described in this article, your use of git:// will start breaking any consumer of your package's CI. after March 24, you will start receiving lots and lots of complaints.

@FrozenPyrozen
Copy link

@CharlesMangwa please merge it, a lot of devs need it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants