Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait loop added to address Issue #84 #85

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Wait loop added to address Issue #84 #85

merged 1 commit into from
Jul 10, 2015

Conversation

gnurenga
Copy link
Member

@gnurenga gnurenga commented Jul 9, 2015

I have added a wait loop in startup function of deveserver shell script to avoid server pointing to topdirectory.

This fix can now able to point the output directory.
I request Maintainers to review it.

…directory. This will avoid server to point the top directory and make it to point inside the output directory
@shrayasr
Copy link
Member

Have you tested this out? Since develop_server.sh comes from the Pelican guys, maybe you should file an issue with them as well?

If this is tested, I'll merge it in.

@gnurenga
Copy link
Member Author

I have tested @shrayasr . I have mentioned the cause of the issue in #84 ..

@gnurenga
Copy link
Member Author

The issue is because we are running pelican command with --auto-reload option in the background.
See this piece of code we are using & symbol at the end of the line

 $PELICAN --debug --autoreload -r $INPUTDIR -o $OUTPUTDIR -s $CONFFILE $PELICANOPTS &

when the shell script excutes each line, the above code excuted and run in the background , i.e script wont wait till it creates output directory, it start executing next lines. when the cd command execute there wont be any output directory. So we are running the pelcian.server in the basedirectory not in the output directory.

Is my explanation is clear ? or confusing

@shrayasr
Copy link
Member

Very clear sir 👍

My point is that the file: develop_server.sh is a file that is given to us when we run pelican quickstart which means that it is provided by the pelican team here.

This seems like a genuine enough issue to me to be reported to Pelican itself.

shrayasr added a commit that referenced this pull request Jul 10, 2015
Wait loop added to address Issue #84
@shrayasr shrayasr merged commit 9edff5f into Chennaipy:master Jul 10, 2015
@gnurenga
Copy link
Member Author

@shrayasr actually we cant file an issue.
Just now i found that pelican-quickstart generating a default output directory.
But in our website repo we dont have default output directory.
If we have default output directory then this fix is not required.
Sorry i didnt checked with pelican-quickstart i thought the script was written by us.

@gnurenga
Copy link
Member Author

ouptut of pelican-quickstart

rengaraj@gnu:~/test$ pelican-quickstart 
Welcome to pelican-quickstart v3.5.0.

This script will help you create a new Pelican-based website.

Please answer the following questions so this script can generate the files
needed by Pelican.


> Where do you want to create your new web site? [.]  
> What will be the title of this web site? Hello
> Who will be the author of this web site? rengaraj
> What will be the default language of this web site? [en] 
> Do you want to specify a URL prefix? e.g., http://example.com   (Y/n) n
> Do you want to enable article pagination? (Y/n) y
> How many articles per page do you want? [10] 
> Do you want to generate a Fabfile/Makefile to automate generation and publishing? (Y/n) 
> Do you want an auto-reload & simpleHTTP script to assist with theme and site development? (Y/n) 
> Do you want to upload your website using FTP? (y/N) 
> Do you want to upload your website using SSH? (y/N) 
> Do you want to upload your website using Dropbox? (y/N) 
> Do you want to upload your website using S3? (y/N) 
> Do you want to upload your website using Rackspace Cloud Files? (y/N) 
> Do you want to upload your website using GitHub Pages? (y/N) 
Done. Your new project is available at /home/rengaraj/test

rengaraj@gnu:~/test$ ls
content  develop_server.sh  fabfile.py  Makefile  output  pelicanconf.py  publishconf.py

@shrayasr
Copy link
Member

Right but it also seems like their own Makefile is removing that output directory. Check here.

@gnurenga
Copy link
Member Author

@shrayasr ok then we can file an issue. Will do that

@shrayasr
Copy link
Member

👍

@gnurenga
Copy link
Member Author

Raised an issue with pelican.
getpelican/pelican#1781

@shrayasr
Copy link
Member

On Wed, Jul 15, 2015 at 12:26 PM, Rengaraj [email protected] wrote:

Raised an issue with pelican.
getpelican/pelican#1781
getpelican/pelican#1781

​Awesomeness! :) ​

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants