Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: patched for readily usable engine #355

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Angular: patched for readily usable engine #355

merged 1 commit into from
Oct 29, 2024

Conversation

hollowaykeanho
Copy link
Member

It appears the existing Angular engine is a work-in-progress one. Hence, let's update it to generate a SEO-capable and search friendly static website seamlessly. Hence, let's do this.

This patch upgrades the Angular engine to a readily usable engine in Angular/ directory.

@hollowaykeanho hollowaykeanho self-assigned this Oct 29, 2024
Copy link
Contributor

@corygalyna corygalyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed review. There is 1 problem. Please fix it.

Angular/.ci/test_unix-any.sh Outdated Show resolved Hide resolved
It appears the existing Angular engine is a work-in-progress
one. Hence, let's update it to generate a SEO-capable and search
friendly static website seamlessly. Hence, let's do this.

This patch upgrades the Angular engine to a readily usable engine
in Angular/ directory.

Co-authored-by: Shuralyov, Jean <[email protected]>
Co-authored-by: Galyna, Cory <[email protected]>
Co-authored-by: (Holloway) Chew, Kean Ho <[email protected]>
Signed-off-by: (Holloway) Chew, Kean Ho <[email protected]>
Copy link
Member Author

@hollowaykeanho hollowaykeanho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scanned cleared. Please review again.

Copy link
Contributor

@JeanShuralyov JeanShuralyov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice graphics! All cleared from my side.

Copy link
Contributor

@corygalyna corygalyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. All cleared!

@corygalyna corygalyna merged commit 8d741ac into next Oct 29, 2024
3 checks passed
@ChewKeanHo ChewKeanHo locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants