-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: patched for readily usable engine #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed review. There is 1 problem. Please fix it.
It appears the existing Angular engine is a work-in-progress one. Hence, let's update it to generate a SEO-capable and search friendly static website seamlessly. Hence, let's do this. This patch upgrades the Angular engine to a readily usable engine in Angular/ directory. Co-authored-by: Shuralyov, Jean <[email protected]> Co-authored-by: Galyna, Cory <[email protected]> Co-authored-by: (Holloway) Chew, Kean Ho <[email protected]> Signed-off-by: (Holloway) Chew, Kean Ho <[email protected]>
49116e9
to
8018485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scanned cleared. Please review again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice graphics! All cleared from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. All cleared!
It appears the existing Angular engine is a work-in-progress one. Hence, let's update it to generate a SEO-capable and search friendly static website seamlessly. Hence, let's do this.
This patch upgrades the Angular engine to a readily usable engine in Angular/ directory.