Link chiapos before blake3 #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
approved these changes
Oct 30, 2024
Pull Request Test Coverage Report for Build 11598691853Details
💛 - Coveralls |
cmmarslender
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure to put
-lchiapos_staticon the link line before-lblake3Jobs starting failing in newer ubuntu runner image - previous jobs succeeded using
Image: ubuntu-22.04 Version: 20240901.1.0but are failing inImage: ubuntu-22.04 Version: 20241015.1.0likely due to some update in clang or ld which is being somewhat more strict and or smarter on resolving static library dependencies in that the library the resolves the symbols should go after the library that uses it.