Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port BLS operators to use chia-bls (and BLST) #345

Merged
merged 2 commits into from
Dec 7, 2023
Merged

port BLS operators to use chia-bls (and BLST) #345

merged 2 commits into from
Dec 7, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 31, 2023 •
edited
Loading

This patch drops the dependency on bls12_381 and replaces it with chia-bls. The motivations for this are:

  • use BLST as the underlying BLS library (which is faster, especially on ARM)
  • cull the dependency tree to reduce supply-chain risk

Perhaps it would make even more sense to use BLST's rust bindings directly in here. I consider this PR a step closer to that

@coveralls-official
Copy link

coveralls-official bot commented Oct 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7116860593

  • 50 of 50 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 92.984%
Totals Coverage Status
Change from base Build 7116742271: -0.06%
Covered Lines: 5275
Relevant Lines: 5673
💛 - Coveralls

@arvidn arvidn force-pushed the chia-bls branch 3 times, most recently from cf34272 to 95115d9 Compare October 31, 2023 22:44
@arvidn arvidn force-pushed the chia-bls branch 2 times, most recently from 5df205b to e48e94d Compare November 25, 2023 15:50
@arvidn arvidn marked this pull request as ready for review November 25, 2023 16:42
@arvidn arvidn marked this pull request as draft December 3, 2023 13:29
@arvidn
port BLS operators to use chia-bls (and BLST)
578d20c
@arvidn
relax specific versions of dependencies. this allows deduplication of…
fa15567 
… the sha2 crate. Only the top level crate should lock down versions of dependencies, with the lockfile
@arvidn arvidn marked this pull request as ready for review December 6, 2023 16:24
@arvidn arvidn merged commit 22b308e into main Dec 7, 2023
29 checks passed
@arvidn arvidn deleted the chia-bls branch December 7, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardkiss richardkiss richardkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvidn @richardkiss