Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add black box marker to hash benchmark #441

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jack60612
Copy link
Contributor

No description provided.

@jack60612
Copy link
Contributor Author

performance stayed the same.

Rigidity
Rigidity previously approved these changes Jul 14, 2024
Copy link

coveralls-official bot commented Jul 14, 2024

Pull Request Test Coverage Report for Build 10226110934

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 94.075%

Files with Coverage Reduction New Missed Lines %
src/allocator.rs 4 98.11%
Totals Coverage Status
Change from base Build 9895604796: -0.08%
Covered Lines: 5779
Relevant Lines: 6143

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Jul 26, 2024

@jack60612 cargo fmt is failing

@arvidn
Copy link
Contributor

arvidn commented Jul 26, 2024

this is what I get on a Mac M1:

rust implementation:

sha256_hash/hash_benchmark
                        time:   [619.71 µs 621.33 µs 623.79 µs]

with openssl:

sha256_hash/hash_benchmark
                        time:   [310.09 µs 310.47 µs 310.92 µs]
                        change: [-50.029% -49.924% -49.824%] (p = 0.00 < 0.05)
                        Performance has improved.

@jack60612
Copy link
Contributor Author

@jack60612 cargo fmt is failing

oh i missed this

@jack60612
Copy link
Contributor Author

changed my config to auto run fmt

@jack60612 jack60612 requested a review from Rigidity August 3, 2024 06:54
@arvidn
Copy link
Contributor

arvidn commented Aug 20, 2024

there's still a clippy failure. the README.md has instructions on how to set up pre-commit

Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants