Videos now prioritize playing to the end over slideshow timer (and random sort in personal list) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uses a ticker to be able to tell if the video playing has finished at least once so video playback is prioritized over slideshow interval. The check for when the video finishes loading has been removed in the favorites section due to sites manager not handling that well there.
…allowing slideshow to continue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the timer of the slideshow and personal list to an interval
Model has a slideshow lock in place that gets activated when a video (and not an image) is loaded
View now notifies when the video has looped, allowing for some future shenanigans, now it just turns off the lock of the slideshow that prevents the ticker from changing to the next slide if the video hasn't played entirely once.
The new timer system also has personal list slideshow mode working again, even though the sites manager callback for when the content has finished loading has been deleted and the slidwshow mode of the personal list just does not care about that (yet).
No option to override this has been added, as this sounds like the proper intended behaviour (fast paced short content, allowing short loops to run multiple times before switching and full length long videos)
Additionally, "sort:random" now works as a filter in the personal list. Any "sort" is detected and filtered out of the tags list, but if sort:random is used, then the filtered list will be shuffled, which is neat.