Fix start time with web video player

Chocobozzz · Oct 27, 2023 · 049f50b · 049f50b
1 parent 2809ebb
commit 049f50b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/client/src/assets/player/peertube-player.ts b/client/src/assets/player/peertube-player.ts
@@ -168,8 +168,7 @@ export class PeerTubePlayer {
     const webVideoOptionsBuilder = new WebVideoOptionsBuilder(pick(this.currentLoadOptions, [
       'videoFileToken',
       'webVideo',
-      'hls',
-      'startTime'
+      'hls'
     ]))
 
     this.player.webVideo(webVideoOptionsBuilder.getPluginOptions())

diff --git a/client/src/assets/player/shared/peertube/peertube-plugin.ts b/client/src/assets/player/shared/peertube/peertube-plugin.ts
@@ -409,11 +409,10 @@ class PeerTubePlugin extends Plugin {
 
     // Prefer canplaythrough instead of canplay because Chrome has issues with the second one
     this.player.one('canplaythrough', () => {
-      if (this.options.startTime()) {
-        debugLogger('Start the video at ' + this.options.startTime())
+      const startTime = this.options.startTime() || 0
+      debugLogger('Start the video at ' + startTime)
 
-        this.player.currentTime(timeToInt(this.options.startTime()))
-      }
+      this.player.currentTime(timeToInt(startTime))
 
       if (this.options.stopTime()) {
         const stopTime = timeToInt(this.options.stopTime())

diff --git a/client/src/assets/player/shared/player-options-builder/web-video-options-builder.ts b/client/src/assets/player/shared/player-options-builder/web-video-options-builder.ts
@@ -14,9 +14,7 @@ export class WebVideoOptionsBuilder {
 
       videoFiles: this.options.webVideo.videoFiles.length !== 0
         ? this.options.webVideo.videoFiles
-        : this.options?.hls.videoFiles || [],
-
-      startTime: this.options.startTime
+        : this.options?.hls.videoFiles || []
     }
   }
 }
diff --git a/client/src/assets/player/types/peertube-videojs-typings.ts b/client/src/assets/player/types/peertube-videojs-typings.ts
@@ -191,7 +191,6 @@ type TheaterButtonOptions = {
 
 type WebVideoPluginOptions = {
   videoFiles: VideoFile[]
-  startTime: number | string
   videoFileToken: () => string
 }