Group IP settings, add default label value to prevent error

ChrisTerBeke · Nov 4, 2024 · 259abe6 · 259abe6
1 parent cdf2a69
commit 259abe6
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 38 deletions.
diff --git a/app.json b/app.json
@@ -80,27 +80,36 @@
       ],
       "settings": [
         {
-          "id": "discovered_address",
-          "label": {
-            "en": "IP Address",
-            "nl": "IP-adres"
-          },
-          "type": "label",
-          "required": false,
-          "highlight": true
-        },
-        {
-          "id": "address",
+          "type": "group",
           "label": {
-            "en": "Override IP Address",
-            "nl": "IP-adres overschrijven"
+            "en": "IP address",
+            "nl": "IP addres"
           },
-          "type": "text",
-          "required": false,
-          "hint": {
-            "en": "Overrides the auto-discovered IP address of the device.",
-            "nl": "Overschrijft het automatisch ontdekte IP-adres van het apparaat."
-          }
+          "children": [
+            {
+              "id": "discovered_address",
+              "label": {
+                "en": "Auto-discovered address",
+                "nl": "Automatisch ontdekte adres"
+              },
+              "type": "label",
+              "required": false,
+              "value": ""
+            },
+            {
+              "id": "address",
+              "label": {
+                "en": "Override IP Address",
+                "nl": "IP-adres overschrijven"
+              },
+              "type": "text",
+              "required": false,
+              "hint": {
+                "en": "Overrides the auto-discovered IP address of the device.",
+                "nl": "Overschrijft het automatisch ontdekte IP-adres van het apparaat."
+              }
+            }
+          ]
         },
         {
           "type": "group",

diff --git a/drivers/uponor/driver.compose.json b/drivers/uponor/driver.compose.json
@@ -43,27 +43,36 @@
     ],
     "settings": [
         {
-            "id": "discovered_address",
-            "label": {
-                "en": "IP Address",
-                "nl": "IP-adres"
-            },
-            "type": "label",
-            "required": false,
-            "highlight": true
-        },
-        {
-            "id": "address",
+            "type": "group",
             "label": {
-                "en": "Override IP Address",
-                "nl": "IP-adres overschrijven"
+                "en": "IP address",
+                "nl": "IP addres"
             },
-            "type": "text",
-            "required": false,
-            "hint": {
-                "en": "Overrides the auto-discovered IP address of the device.",
-                "nl": "Overschrijft het automatisch ontdekte IP-adres van het apparaat."
-            }
+            "children": [
+                {
+                    "id": "discovered_address",
+                    "label": {
+                        "en": "Auto-discovered address",
+                        "nl": "Automatisch ontdekte adres"
+                    },
+                    "type": "label",
+                    "required": false,
+                    "value": ""
+                },
+                {
+                    "id": "address",
+                    "label": {
+                        "en": "Override IP Address",
+                        "nl": "IP-adres overschrijven"
+                    },
+                    "type": "text",
+                    "required": false,
+                    "hint": {
+                        "en": "Overrides the auto-discovered IP address of the device.",
+                        "nl": "Overschrijft het automatisch ontdekte IP-adres van het apparaat."
+                    }
+                }
+            ]
         },
         {
             "type": "group",