Do not create client twice when address changes

ChrisTerBeke · Jul 2, 2024 · ab4c4b6 · ab4c4b6
1 parent 13f61be
commit ab4c4b6
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/drivers/uponor/device.ts b/drivers/uponor/device.ts
@@ -53,22 +53,14 @@ class UponorThermostatDevice extends Device {
 
     private async _updateAddress(newAddress: string, persist = false): Promise<boolean> {
         if (newAddress && newAddress.length > 0) {
-            const isValidIP = isIPv4(newAddress)
-            if (!isValidIP) return false
-            const client = new UponorHTTPClient(newAddress)
-            try {
-                const canConnect = await client.testConnection()
-                if (!canConnect) return false
-            } catch (error) {
-                return false
-            }
+            if (!isIPv4(newAddress)) return false
         }
 
         if (persist) {
-            this.setStoreValue('address', newAddress)
+            await this.setStoreValue('address', newAddress)
         }
 
-        this._init()
+        await this._init()
         return true
     }