Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security patch: temp-dir #749

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Oct 3, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • tempdir crate is not maintained and contains security vulnerabilities.
  • tempdir depends on old version of remove_dir_all and is heavy weight.
  • temp-dir an alternative to tempdir is light weight and is actively maintained.
  • Found this security vulnerability in private linutil repo ( Not forked , used for CI testing sometimes )
    alert

Testing

  • Works without issues.

Impact

  • TempDir is now needed to be passed into the AppState to retain the tempdir until the end of the program.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech ChrisTitusTech merged commit 26d0adc into ChrisTitusTech:main Oct 3, 2024
1 check passed
@jeevithakannan2 jeevithakannan2 deleted the refact-tempdir branch October 3, 2024 19:23
afonsofrancof pushed a commit to afonsofrancof/linutil that referenced this pull request Oct 3, 2024
lennartpj pushed a commit to lennartpj/linutil that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants