Update Prometheus compose templates, add helm and kubernetes templates #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lute path to /etc/prometheus which is prescribed in "Server Monitoring Prometheus and Grafana Tutorial" (Sep 21, 2021).
|
Good point! Ideally, all boilerplates snippets should be inline with the video tutorials. But that's a huge task to do, because things change from time to time, and I'm unable to update all videos the same way. However, things will be addressed somewhere next year, I'm planning to make a new Prometheus video that includes metrics from Kubernetes and Alerts. I will update the config to be more aligned. |
ChristianLempa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Hello, in Server Monitoring // Prometheus and Grafana Tutorial (Sep 21, 2021) Christian prescribes creating the /etc/prometheus directory to store the prometheus.yaml config file.
As of today, the boilerplate repository specifies the prometheus.yaml bind mount source path as ./config/prometheus.yaml
I feel this introduces two problems as config/prometheus.yaml is now incongruent with the guide and using ./ (relative path) gave me issues too. Using / (absolute path) seems like the more reliable option.
If the repo team would like to keep /config/prometheus.ymal or etc/prometheus/config/prometheus.yaml, I can go in that direction and include a read.me for future users.