Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Issues with Fetching and Displaying GitHub Contributors #358

Closed
1 task done
Swapnilden opened this issue Jun 28, 2024 · 2 comments · Fixed by #373
Closed
1 task done

[Bug]: Issues with Fetching and Displaying GitHub Contributors #358

Swapnilden opened this issue Jun 28, 2024 · 2 comments · Fixed by #373
Assignees

Comments

@Swapnilden
Copy link
Contributor

Give a brief about the bug ✍️

The code fetching and displaying GitHub contributors has several issues, including a hardcoded page parameter, inefficient DOM updates, and global variable scope problems.

What is the expected behavior? 🤔

  • The function getContributors should correctly fetch contributors across multiple pages.
  • The contributors should be sorted and displayed in the correct order.
  • The search functionality should work without undefined variables.
  • The DOM should be updated efficiently to improve performance.

Provide step by step information to reproduce the bug 📄

  1. Hardcoded Page Parameter
  • Open the code and locate the getContributors function.
  • Notice that the page parameter in the fetch URL is hardcoded to 1.
  1. Inefficient DOM Updates
  • Observe the DOM update logic within the window.onload function.
  • Notice the repeated DOM manipulations without using DocumentFragment.
  1. Undefined data Variable in Search
  • Check the searchResult.addEventListener function.
  • Notice the data variable is not defined globally, causing errors when the search input is used.
  1. Inconsistent Dark Mode Toggle Event Listeners
  • Examine the event listeners for dark mode toggle.
  • Notice duplicated event listeners and possible issues with theme toggling.

Select program in which you are contributing

GSSoC24

Code of Conduct

@github-actions github-actions bot added the gssoc label Jun 28, 2024
Copy link

Hey @Swapnilden! 👋

👉 Thanks for opening this issue. We appreciate your contribution and will look into it as soon as possible.
👉 Don’t forget to star our Community Page and Follow Us on GitHub
👉 Make sure you join our Discord, we have created separate channels for all projects

Copy link

Thank you for your contribution! If you have any questions or need further assistance, feel free to reach out to us on our Discord server: Discord. We have separate channels for all projects. Happy coding! 🚀

Connect with us on social media:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants