Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update script.js #373

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Update script.js #373

merged 3 commits into from
Jul 23, 2024

Conversation

Swapnilden
Copy link
Contributor

PR Description 📜

This PR addresses several issues related to the fetching and displaying of GitHub contributors. The following improvements have been made:

  • Corrected the hardcoded page parameter and added pagination to fetch all contributors.
  • Optimized DOM updates using DocumentFragment to enhance performance.
  • Ensured the data variable is globally accessible for the search functionality.
  • Consolidated and streamlined event listeners, especially for dark mode toggling and Discord popup handling.
    Fixes [Bug]: Issues with Fetching and Displaying GitHub Contributors #358

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [] I have added screenshot for review.

Thank you soo much for contributing to our repository 💗

Copy link

vercel bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
community-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 3:03pm

Copy link
Collaborator

@Manaregr8 Manaregr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you removed Rating function in your script.js and its related functions....? it leads to non functioning Rate us button
Please explain

Copy link
Contributor Author

@Swapnilden Swapnilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Manaregr8 I appreciate your feedback regarding the recent changes I made to the script.js file. The removal of the Rating function and its related functions was an unintentional oversight during the process of updating the contributors' functionality.

Here's a more explanation of what happened:

  • Focus on Contributors:

My primary task was to enhance how contributors are fetched from the GitHub API and displayed on the webpage. This involved updating the functions that retrieve and present the list of contributors.

  • Unintentional Removal:

In the process of streamlining and cleaning up the code, I mistakenly removed some functions related to the rating feature. These functions were responsible for updating the slider value, handling feedback submissions, and managing the "Rate us" modal.

  • Impact on the "Rate us" Button:

The removal of these functions caused the "Rate us" button to stop working because the essential code supporting its functionality was missing. This was an unintended consequence of the changes I made.

  • Resolution:

I recognize the importance of the "Rate us" feature and promptly re-integrate the removed functions to ensure it works correctly.

I apologize for any inconvenience caused and will ensure that such issues are avoided in the future. Thank you for bringing this to my attention.

Copy link
Collaborator

@Manaregr8 Manaregr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicelly Donee!!

@Manaregr8 Manaregr8 merged commit c358aa4 into ChromeGaming:main Jul 23, 2024
2 checks passed
@Swapnilden
Copy link
Contributor Author

@Manaregr8 thanks for compliment!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issues with Fetching and Displaying GitHub Contributors
2 participants