-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update script.js #373
Update script.js #373
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you removed Rating function in your script.js and its related functions....? it leads to non functioning Rate us button
Please explain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Manaregr8 I appreciate your feedback regarding the recent changes I made to the script.js file. The removal of the Rating function and its related functions was an unintentional oversight during the process of updating the contributors' functionality.
Here's a more explanation of what happened:
- Focus on Contributors:
My primary task was to enhance how contributors are fetched from the GitHub API and displayed on the webpage. This involved updating the functions that retrieve and present the list of contributors.
- Unintentional Removal:
In the process of streamlining and cleaning up the code, I mistakenly removed some functions related to the rating feature. These functions were responsible for updating the slider value, handling feedback submissions, and managing the "Rate us" modal.
- Impact on the "Rate us" Button:
The removal of these functions caused the "Rate us" button to stop working because the essential code supporting its functionality was missing. This was an unintended consequence of the changes I made.
- Resolution:
I recognize the importance of the "Rate us" feature and promptly re-integrate the removed functions to ensure it works correctly.
I apologize for any inconvenience caused and will ensure that such issues are avoided in the future. Thank you for bringing this to my attention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicelly Donee!!
@Manaregr8 thanks for compliment!! |
PR Description 📜
This PR addresses several issues related to the fetching and displaying of GitHub contributors. The following improvements have been made:
page
parameter and added pagination to fetch all contributors.DocumentFragment
to enhance performance.data
variable is globally accessible for the search functionality.Fixes [Bug]: Issues with Fetching and Displaying GitHub Contributors #358
Mark the task you have completed ✅
Thank you soo much for contributing to our repository 💗