Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activepages #348

Closed
wants to merge 4 commits into from
Closed

Conversation

NeerajaGurram
Copy link
Contributor

PR Description 📜

changes made such that the current active page can be known seeing the navbar
before:

image

after:

Chrome.Gaming._.Home.-.Google.Chrome.2024-06-23.00-08-38_Trim.mp4

Fixes #336

let me know if there can be made any changes to improve. i would like to work on them.
Thankyou.


Mark the task you have completed ✅

  • [x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [ x] I have performed a self-review of my own code or work.
  • [ x] I have commented my code, particularly in hard-to-understand areas.
  • [ x] My changes generates no new warnings.
  • [ x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ x] I have added screenshot for review.

## Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
community-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 6:52pm

@Ridhima10
Copy link
Contributor

Ridhima10 commented Jun 22, 2024

@Manaregr8
i have designed the navbar so kindly note the active link should have specified border bottom too. Thats what makes it unique and attractive
Just suggesting, its upto you obviously

@NeerajaGurram
Copy link
Contributor Author

made few changes in the pr #350 for the same issue.
@Manaregr8
choose which one is appropriate :)
Thankyou.

@Manaregr8
Copy link
Collaborator

Nice coordination @NeerajaGurram @Ridhima10 guys keep it up!

nicely done @NeerajaGurram!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: effect on active navbar link indicating the page in which the user is in
3 participants