Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced The Timer Functionality and Restore the Game Interface #640

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

MastanSayyad
Copy link
Contributor

@MastanSayyad MastanSayyad commented Jul 27, 2024

PR Description 📜

Hey @ayush-t02

Issue fixes #631

I have Fix the Issues in the game interface and Enhanced the timer functionality

  • To make it easily accessible (in Both mobile and desktop view)
  • Made required adjustments to avoid overlapping on the game board
  • Fix the Code overflow from the body
  • Added additional tour step introducing Timer functionality
  • FIx the alignments and the positioning of tour steps with the new changes

image

image

image

image

image

I have ensure each game component does not overlap with each other and work independently!


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.



Thank you soo much for contributing to our repository 💗

@MastanSayyad
Copy link
Contributor Author

Hey @ayush-t02 I have fixed the issue and ensured the timer or any other component functionality does not overlap

@MastanSayyad
Copy link
Contributor Author

@ayush-t02 pls take a look at this pr and review it!

@ayush-t02
Copy link
Collaborator

resolve conflicts

@MastanSayyad
Copy link
Contributor Author

@ayush-t02 I have resolved the conflicts

@MastanSayyad
Copy link
Contributor Author

Also, remove the level 3 label as I think someone fixed the breaking issue before me so the only work I have done is to enhance the timer functionality, and its position and add a new tour step introducing the timer and some other changes so I should get only level 2 for this. just to keep it fair! @ayush-t02

@ayush-t02 ayush-t02 added level2 and removed level3 labels Jul 28, 2024
@ayush-t02 ayush-t02 merged commit 0612231 into ChromeGaming:main Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tour Guide Broke By The Recent Chnages
2 participants