Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY - Don't Repeat yourself implemented #679

Merged
merged 6 commits into from
Aug 3, 2024
Merged

Conversation

hars-21
Copy link
Contributor

@hars-21 hars-21 commented Aug 3, 2024

PR Description 📜

Removed the redundant code
Added global.js and global.css files that contains same code for every page like:
Loader
Cursor animation
Scroll to top

Fixes #653


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for review.

## Add your screenshots(Optional) 📸

Screen Shot 2024-08-03 at 1 20 29 PM
Screen Shot 2024-08-03 at 1 20 49 PM
Screen Shot 2024-08-03 at 1 20 17 PM



Thank you soo much for contributing to our repository 💗

@ayush-t02 ayush-t02 merged commit 2df9e4c into ChromeGaming:main Aug 3, 2024
1 check failed
@hars-21 hars-21 deleted the dry branch August 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRY implementation
2 participants