Added cross button in color gradient platte #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Here is the screenshot for the feature and proper working/testing has been performed by me before submitting PR. |
|
@DevanshPaliwal make it transparesnt & add a demo vedio |
|
@Durgesh4993 where should i add the demo video? |
|
Yes |
|
Transparent button and demo video added gradient.palette.demo.mp4 |
|
@Durgesh4993 added changes. |
|
@Durgesh4993 please merge this PR under Gssoc24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below -
Fixes issue #84 , added cross button in gradient palette, even if both colors are selected and we press this cross button, those colors will not be changed. There is the apply gradient button for that. This cross button correctly closes the gradient palette without any problem.
Mark the task you have completed ✅
## Add your screenshots(Optional) 📸
Screenshot is added in comments
Thank you soo much for contributing to our repository 💗