Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Commit

Permalink
fix: orb import failing for orbs with default executors (#275)
Browse files Browse the repository at this point in the history
* fix: orb import failing for orbs with default executors

* feat: lowered min zoom for big configs
  • Loading branch information
Jaryt authored Aug 23, 2022
1 parent f970a5d commit 97594de
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.0-development",
"homepage": "https://circleci-public.github.io/visual-config-editor/",
"dependencies": {
"@circleci/circleci-config-sdk": "v0.9.0-alpha.15",
"@circleci/circleci-config-sdk": "v0.9.0-alpha.16",
"@craco/craco": "^6.3.0",
"@monaco-editor/react": "^4.3.1",
"algoliasearch": "^4.13.1",
Expand Down
1 change: 1 addition & 0 deletions src/components/containers/WorkflowContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ const WorkflowContainer = ({ bgClassName, className }: ElementProps) => {
nodeTypes={getTypes()}
edgeTypes={{ requires: Edge }}
snapToGrid={true}
minZoom={0.1}
connectionMode={ConnectionMode.Loose}
connectionLineComponent={
ConnectionLine as React.ComponentType<ConnectionLineComponentProps>
Expand Down
14 changes: 12 additions & 2 deletions src/components/menus/definitions/OrbDefinitionsMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,13 @@ const OrbDefinitionsMenu = (props: OrbDefinitionProps) => {
</a>
</div>
<div className="flex flex-row mt-3">
<img className="w-8 h-8 mx-1" src={props.logo_url} alt="" />
<div className="rounded-full bg-white shadow flex w-8 h-8 p-px">
<img
className="rounded-full my-auto"
src={props.logo_url}
alt=""
/>
</div>
<h1 className="ml-2 text-xl font-thin text-circle-gray-500">
{props.namespace}/
</h1>
Expand Down Expand Up @@ -250,7 +256,11 @@ const OrbDefinitionMenuNav: NavigationComponent = {
return <p>{props.name}</p>;
},
Icon: (props: OrbDefinitionProps) => {
return <img className="w-4 h-4 mx-1" src={props.logo_url} alt="" />;
return (
<div className="w-4 h-4 rounded-full flex shadow">
<img className="my-auto" src={props.logo_url} alt="" />
</div>
);
},
};

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1204,10 +1204,10 @@
resolved "https://registry.npmjs.org/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz"
integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==

"@circleci/[email protected].15":
version "0.9.0-alpha.15"
resolved "https://registry.yarnpkg.com/@circleci/circleci-config-sdk/-/circleci-config-sdk-0.9.0-alpha.15.tgz#34c124f10b27c4fadab2251171ccb3c0d615d320"
integrity sha512-8v+dKnIHWy05mdyyKd8/UQlX8cXSbYe1+F9a3yC9Jqhj8vvAwcpPRuvFCacxTguPJn5lGIMDUV3ic0pSMsjihw==
"@circleci/[email protected].16":
version "0.9.0-alpha.16"
resolved "https://registry.yarnpkg.com/@circleci/circleci-config-sdk/-/circleci-config-sdk-0.9.0-alpha.16.tgz#4a6669b8aeea5fe6f8f1fb9bebeae6fb4989f094"
integrity sha512-MKp1INEh7Rb0Mr46e6bLf+NsTyobl9IzmaQVDh7k0ul6Aez6gVE85IylY0MEsuUvyqjXZe9+99A5NGQ0K5cZnQ==
dependencies:
ajv "^8.8.2"
ajv-merge-patch "^5.0.1"
Expand Down

0 comments on commit 97594de

Please sign in to comment.