Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty state missing#97 #157

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

jassi-singh
Copy link
Contributor

Fixes #97 and #100

Describe the changes you have made in this PR -

  • Added Empty State for both types of groups (Mentored and Joined).
  • Changed create Group button to the floating button.
  • Added tabs for Mentored and Joined groups.

Screenshots of the changes (If any) -

Tab with groups Tab with no group
image image

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@manjotsidhu manjotsidhu requested a review from nitin10s October 11, 2021 06:38
@manjotsidhu
Copy link
Member

manjotsidhu commented Oct 11, 2021

@jassi-singh Thanks for contributing, a few minor things we have to do -

@manjotsidhu
Copy link
Member

manjotsidhu commented Oct 14, 2021

@jassi-singh are you working on it ?

@jassi-singh
Copy link
Contributor Author

@jassi-singh are you working on it ?

yes @manjotsidhu got little occupied yesterday will make a PR by tonight

@coveralls
Copy link

coveralls commented Oct 14, 2021

Pull Request Test Coverage Report for Build 1341784343

  • 32 of 46 (69.57%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 73.555%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/groups/my_groups_view.dart 31 45 68.89%
Files with Coverage Reduction New Missed Lines %
lib/ui/views/groups/my_groups_view.dart 1 65.75%
Totals Coverage Status
Change from base Build 1338307942: -0.1%
Covered Lines: 3855
Relevant Lines: 5241

💛 - Coveralls

Copy link
Member

@manjotsidhu manjotsidhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@manjotsidhu manjotsidhu requested a review from Nitish145 October 14, 2021 13:59
@manjotsidhu manjotsidhu merged commit 36edacf into CircuitVerse:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Empty State Icon/Message missing.
4 participants