fix(lints): multiple linter rules #149

analysis_options.yaml

@@ -8,8 +8,6 @@ linter:
     # Util classes
     avoid_classes_with_only_static_members: false
 
-    avoid_redundant_argument_values: false
-
     non_constant_identifier_names: false
 
     constant_identifier_names: false

lib/services/database_service.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/foundation.dart';
-import 'package:hive/hive.dart';
 import 'package:hive_flutter/hive_flutter.dart';
 import 'package:mobile_app/models/ib/ib_raw_page_data.dart';
 

lib/ui/components/cv_password_field.dart

@@ -1,5 +1,4 @@
 import 'package:flutter/material.dart';
-import 'package:flutter/services.dart';
 import 'package:mobile_app/cv_theme.dart';
 
 class CVPasswordField extends StatefulWidget {

lib/ui/views/groups/add_assignment_view.dart

@@ -146,7 +146,7 @@ class _AddAssignmentViewState extends State<AddAssignmentView> {
           value: _restrictions.contains(name),
           onChanged: (value) {
             if (value) {
-              _restrictions.add((name));
+              _restrictions.add(name);
             } else {
               _restrictions.remove(name);
             }

lib/ui/views/groups/assignment_details_view.dart

@@ -2,7 +2,6 @@ import 'dart:convert';
 
 import 'package:flutter/material.dart';
 import 'package:flutter_html/flutter_html.dart';
-import 'package:flutter_html/style.dart';
 import 'package:get/get.dart';
 import 'package:intl/intl.dart';
 import 'package:mobile_app/cv_theme.dart';

lib/ui/views/groups/update_assignment_view.dart

@@ -126,7 +126,7 @@ class _UpdateAssignmentViewState extends State<UpdateAssignmentView> {
             value: _restrictions.contains(name),
             onChanged: (value) {
               if (value) {
-                _restrictions.add((name));
+                _restrictions.add(name);
               } else {
                 _restrictions.remove(name);
               }

lib/ui/views/ib/builders/ib_webview_builder.dart

@@ -1,6 +1,5 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_html/flutter_html.dart';
-import 'package:flutter_html/html_parser.dart';
 import 'package:flutter_markdown/flutter_markdown.dart';
 import 'package:webview_flutter/webview_flutter.dart';
 import 'package:markdown/markdown.dart' as md;

lib/ui/views/projects/project_details_view.dart

@@ -1,7 +1,6 @@
 import 'package:flutter/gestures.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_html/flutter_html.dart';
-import 'package:flutter_html/style.dart';
 import 'package:get/get.dart';
 import 'package:mobile_app/cv_theme.dart';
 import 'package:mobile_app/config/environment_config.dart';

lib/utils/router.dart

@@ -1,4 +1,3 @@
-import 'package:flutter/cupertino.dart';
 import 'package:flutter/material.dart';
 import 'package:mobile_app/models/assignments.dart';
 import 'package:mobile_app/models/groups.dart';

test/service_tests/assignments_api_test.dart

@@ -189,7 +189,7 @@ void main() {
             (_) => Future.value(Response('{"message": "reopened"}', 200)));
         var _assignmentsApi = HttpAssignmentsApi();
 
-        expect((await _assignmentsApi.reopenAssignment('1')), 'reopened');
+        expect(await _assignmentsApi.reopenAssignment('1'), 'reopened');
       });
 
       test('When called & http client throws Exceptions', () async {
@@ -219,7 +219,7 @@ void main() {
             Future.value(Response('{"message": "project created"}', 200)));
         var _assignmentsApi = HttpAssignmentsApi();
 
-        expect((await _assignmentsApi.startAssignment('1')), 'project created');
+        expect(await _assignmentsApi.startAssignment('1'), 'project created');
       });
 
       test('When called & http client throws Exceptions', () async {

test/service_tests/users_api_test.dart

@@ -213,7 +213,7 @@ void main() {
 
         ApiUtils.client = MockClient((_) =>
             Future.value(Response('{"message": "instructions sent"}', 200)));
-        expect((await _usersApi.sendResetPasswordInstructions('[email protected]')),
+        expect(await _usersApi.sendResetPasswordInstructions('[email protected]'),
             true);
       });
 

test/ui_tests/groups/update_assignment_view_test.dart

@@ -1,5 +1,4 @@
 import 'package:datetime_picker_formfield/datetime_picker_formfield.dart';
-import 'package:flutter/cupertino.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:get/get.dart';