Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ndo_l3out_interface_routing_policy to manage L3Out Interface Routing Policy (DCNE-132) #563

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sajagana
Copy link
Collaborator

@sajagana sajagana commented Nov 8, 2024

No description provided.

@github-actions github-actions bot changed the title Added ndo_l3out_interface_routing_policy to manage L3Out Interface Routing Policy Added ndo_l3out_interface_routing_policy to manage L3Out Interface Routing Policy (DCNE-132) Nov 8, 2024
@sajagana sajagana force-pushed the 458_l3out_interface_routing_policy branch from 6e1cc12 to 8535b6c Compare November 8, 2024 15:30
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_l3out_interface_routing_policy.py Outdated Show resolved Hide resolved
@sajagana sajagana requested a review from samiib November 14, 2024 17:07
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
gmicol
gmicol previously approved these changes Dec 9, 2024
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Dec 9, 2024
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 10, 2024
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/module_utils/constants.py Outdated Show resolved Hide resolved
@sajagana sajagana dismissed stale reviews from samiib, shrsr, and gmicol via b7f7bcc December 10, 2024 12:07
akinross
akinross previously approved these changes Dec 11, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Dec 17, 2024
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 18, 2024
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot requested review from samiib and akinross December 18, 2024 21:17
samiib
samiib previously approved these changes Dec 19, 2024
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Jan 8, 2025
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross previously approved these changes Jan 13, 2025
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from akinross, anvitha-jain, samiib, gmicol, and shrsr via d6aef2d January 23, 2025 07:09
@sajagana sajagana force-pushed the 458_l3out_interface_routing_policy branch from d74e155 to d6aef2d Compare January 23, 2025 07:09
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

username: admin
password: SomeSecretPassword
template: ansible_tenant_template
uuid: "{{ query_with_name.current.uuid }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuid: "{{ irp_1_present.current.uuid }}"

mso.exit_json()


def get_ospf_network_type(network_type):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in constants file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for L3Out Interface Routing Policy in Tenant Tenant Policies Template (DCNE-132)
6 participants