Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor changes] Adding new module for interface policy group object. (DCNE-51) #540

Merged
merged 8 commits into from
Nov 27, 2024
Merged

[minor changes] Adding new module for interface policy group object. (DCNE-51) #540

merged 8 commits into from
Nov 27, 2024

Conversation

anvitha-jain
Copy link
Collaborator

No description provided.

@anvitha-jain anvitha-jain linked an issue Sep 30, 2024 that may be closed by this pull request
Enhancement: New module for Interface Settings in Fabric Fabric Policies Template (DCNE-51) #442
Closed
@github-actions github-actions bot changed the title [minor changes] Adding new module for interface policy group object. [minor changes] Adding new module for interface policy group object. (DCNE-51) Oct 1, 2024
@anvitha-jain anvitha-jain force-pushed the interface_setting branch 4 times, most recently from 7a730b7 to 6014282 Compare October 3, 2024 05:52
@anvitha-jain anvitha-jain self-assigned this Oct 3, 2024
akinross
akinross requested changes Oct 7, 2024
View reviewed changes
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain force-pushed the interface_setting branch 2 times, most recently from b70b0cd to 896b2d5 Compare October 8, 2024 21:10
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.34211% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.68%. Comparing base (4fa9818) to head (6966054).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
plugins/modules/ndo_interface_setting.py 99.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #540       +/-   ##
===========================================
+ Coverage   64.16%   81.68%   +17.52%     
===========================================
  Files          91       64       -27     
  Lines        8394     6362     -2032     
  Branches     2196     1693      -503     
===========================================
- Hits         5386     5197      -189     
+ Misses       2713      807     -1906     
- Partials      295      358       +63
Flag Coverage Δ
integration 81.68% <99.34%> (+0.83%) ⬆️
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anvitha-jain anvitha-jain force-pushed the interface_setting branch 3 times, most recently from 084471d to 50fe439 Compare October 10, 2024 22:12
@anvitha-jain anvitha-jain requested a review from akinross October 10, 2024 22:13
@anvitha-jain anvitha-jain force-pushed the interface_setting branch 3 times, most recently from 98075cb to 3becd39 Compare October 11, 2024 01:43
gmicol
gmicol requested changes Oct 11, 2024
View reviewed changes
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
plugins/modules/ndo_interface_setting.py Outdated Show resolved Hide resolved
tests/integration/targets/ndo_interface_setting/tasks/main.yml Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain requested a review from gmicol October 15, 2024 18:30
gmicol
gmicol previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvitha-jain anvitha-jain force-pushed the interface_setting branch 3 times, most recently from f89a91e to 14b47f8 Compare November 13, 2024 22:19
@anvitha-jain
[ignore_changes] Fixing argument names and checks based on recent upd…
8773b38 
…ates made on similar modules to keep the template consistent.
@anvitha-jain anvitha-jain requested a review from gmicol November 14, 2024 19:16
akinross
akinross reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we might need to rebase and use function from this: #569

gmicol
gmicol previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit f65f3d0 into CiscoDevNet:master Nov 27, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

Assignees

@anvitha-jain anvitha-jain

Labels
new_module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for Interface Settings in Fabric Fabric Policies Template (DCNE-51)
7 participants
@anvitha-jain @lhercot @shrsr @akinross @sajagana @samiib @gmicol