Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_changes] Added new module ndo_mac_sec_policy (DCNE-177 DCNE-74) #522

Merged
merged 9 commits into from
Oct 17, 2024
Merged

[minor_changes] Added new module ndo_mac_sec_policy (DCNE-177 DCNE-74) #522

merged 9 commits into from
Oct 17, 2024

Conversation

anvitha-jain
Copy link
Collaborator

@anvitha-jain anvitha-jain commented Aug 22, 2024 •
edited by samiib
Loading

(for macsecPolicies object).
Part of issue #465

@anvitha-jain anvitha-jain added enhancement New feature or request jira-sync Sync this issue to Jira labels Aug 22, 2024
@anvitha-jain anvitha-jain self-assigned this Aug 22, 2024
@anvitha-jain anvitha-jain force-pushed the macsec branch 3 times, most recently from 30c82cd to 3ca81c3 Compare September 10, 2024 16:16
akinross
akinross requested changes Sep 10, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
tests/integration/targets/ndo_mac_sec_policy/tasks/main.yml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.90210% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.47%. Comparing base (55159d6) to head (16c8cd4).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
plugins/modules/ndo_macsec_policy.py 98.50% 0 Missing and 2 partials ⚠️
plugins/module_utils/mso.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #522       +/-   ##
===========================================
+ Coverage   67.72%   81.47%   +13.75%     
===========================================
  Files          85       70       -15     
  Lines        7644     6603     -1041     
  Branches     1982     1721      -261     
===========================================
+ Hits         5177     5380      +203     
+ Misses       2099      795     -1304     
- Partials      368      428       +60
Flag Coverage Δ
integration 81.47% <97.90%> (+2.28%) ⬆️
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot changed the title [minor_changes] Added new module ndo_mac_sec_policy [minor_changes] Added new module ndo_mac_sec_policy (DCNE-177) Sep 13, 2024
samiib
samiib requested changes Sep 17, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
samiib
samiib previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Sep 19, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
akinross
akinross requested changes Sep 19, 2024
View reviewed changes
plugins/modules/ndo_mac_sec_policy.py Outdated Show resolved Hide resolved
shrsr
shrsr previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot requested changes Oct 11, 2024
View reviewed changes
plugins/modules/ndo_macsec_policy.py Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain dismissed stale reviews from shrsr, gmicol, sajagana, akinross, and samiib via 16c8cd4 October 14, 2024 17:18
samiib
samiib previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Oct 16, 2024
View reviewed changes
tests/integration/targets/ndo_macsec_policy/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/ndo_macsec_policy/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/ndo_macsec_policy.py Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain dismissed stale reviews from gmicol and samiib via c004fd2 October 16, 2024 16:20
samiib
samiib approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 102f4e7 into CiscoDevNet:master Oct 17, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

Assignees

@anvitha-jain anvitha-jain

Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anvitha-jain @lhercot @shrsr @akinross @sajagana @samiib @gmicol