[minor_change] Add ndo_tenant_custom_qos_policy for tenant Custom QoS configuration. (DCNE-127) #571
+1,060
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmicol
added
enhancement
gmicol
requested review from
akinross,
anvitha-jain,
lhercot,
sajagana,
samiib and
shrsr
as code owners
samiib
requested changes
Nov 25, 2024
gmicol
force-pushed
the
mso_custom_qos_policy
branch
from
c45f5cf to
a719f0c
Compare
akinross
requested changes
Nov 28, 2024
gmicol
force-pushed
the
mso_custom_qos_policy
branch
from
56cd354 to
c0c938f
Compare
gmicol
force-pushed
the
mso_custom_qos_policy
branch
from
c0c938f to
372d39b
Compare
shrsr
requested changes
Dec 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 72.58% 72.08% -0.50%
==========================================
Files 55 55
Lines 5504 5524 +20
Branches 1462 1468 +6
==========================================
- Hits 3995 3982 -13
- Misses 1174 1196 +22
- Partials 335 346 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmicol
force-pushed
the
mso_custom_qos_policy
branch
from
fdbcbf2 to
3a931b6
Compare
sajagana
requested changes
Dec 6, 2024
gmicol
force-pushed
the
mso_custom_qos_policy
branch
from
855d85f to
8dcb5f7
Compare
lhercot
requested review from
akinross and
anvitha-jain
and removed request for
akinross
anvitha-jain
previously approved these changes
Jan 23, 2025
…nvert pyhton list of dict into equivalent NDO API format.
… Adjust format_list_dict function in module_utils/utils.py.
…_custom_qos_policy.py and utils.py.
…stom_qos_policy module. Modify test case, documentation and format_list_dict in utils.py.
…y ndo_tenant_custom_qos_policy module's documentation.
…affic types for attributes in ndo_tenant_custom_qos_policy.
…ly the changes to ndo_tenant_custom_qos_policy.py and constants.py files.
…t with dict comprehension in ndo_tenant_custom_qos_policy module.
gmicol
dismissed stale reviews from anvitha-jain, shrsr, and akinross
via
6f08e26
gmicol
force-pushed
the
mso_custom_qos_policy
branch
from
8dcb5f7 to
6f08e26
Compare
anvitha-jain
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #453