Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ndo_ntp_policy as a new module for managing NTP Policy objects (DCNE-69) #599

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add ndo_ntp_policy as a new module for managing NTP Policy objects (DCNE-69) #599

wants to merge 3 commits into from

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Jan 21, 2025

resolves #446

@gmicol gmicol added enhancement New feature or request jira-sync Sync this issue to Jira labels Jan 21, 2025
@gmicol gmicol self-assigned this Jan 21, 2025
anvitha-jain
anvitha-jain requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change authentification -> authentication
and add minimum and max values for attributes

plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
tests/integration/targets/ndo_ntp_policy/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Show resolved Hide resolved
@gmicol gmicol requested a review from anvitha-jain January 23, 2025 14:49
@gmicol gmicol force-pushed the mso_ntp_policy branch 2 times, most recently from 484306b to 7528c15 Compare January 23, 2025 17:12
anvitha-jain
anvitha-jain requested changes Jan 23, 2025
View reviewed changes
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
@gmicol gmicol requested a review from anvitha-jain January 24, 2025 18:01
akinross
akinross previously approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Jan 27, 2025
View reviewed changes
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_ntp_policy.py Outdated Show resolved Hide resolved
@gmicol gmicol requested review from shrsr and akinross January 27, 2025 19:07
shrsr
shrsr approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajagana sajagana sajagana approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@samiib samiib Awaiting requested review from samiib samiib is a code owner

@akinross akinross Awaiting requested review from akinross akinross is a code owner

Assignees

@gmicol gmicol

Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for NTP Policy in Fabric Fabric Policies Template (DCNE-69)
5 participants
@gmicol @shrsr @akinross @anvitha-jain @sajagana