[ignore] change all tasks to include FQCN

tests/integration/targets/nd_backup/tasks/main.yml

@@ -38,13 +38,13 @@
   register: add_nexus2
 
 - name: Find backup nexus to ensure that it was created
-  find:
+  ansible.builtin.find:
     paths: "{{ role_path }}/backups"
     patterns: "nexus_{{ ansible_host }}.tgz"
   register: find_nexus
 
 - name: Find backup nexus2 to ensure that it was created
-  find:
+  ansible.builtin.find:
     paths: "{{ role_path }}/backups"
     patterns: "nexus2_{{ ansible_host }}.tgz"
   register: find_nexus2
@@ -139,7 +139,7 @@
   register: delete_wrong_key_nexus
 
 - name: Verify all assertions
-  assert:
+  ansible.builtin.assert:
     that:
     - cm_add_nexus.changed is true
     - cm_add_nexus.current.spec.description == "nexus"

tests/integration/targets/nd_backup_restore/tasks/main.yml

@@ -195,7 +195,7 @@
     query_all_routes_restored3: "{{ query_all_routes_after_third_import.current | map(attribute='spec') | list | sort(attribute='destination') }}"
 
 - name: Verify all assertions
-  assert:
+  ansible.builtin.assert:
     that:
     - restore_nexus_cm.changed is true
     - restore_nexus.changed is true

tests/integration/targets/nd_cluster_config_route/tasks/main.yml

@@ -135,7 +135,7 @@
   register: delete_mgmt_route
 
 - name: Verify all assertions
-  assert:
+  ansible.builtin.assert:
     that:
       - add_data_route_cm.changed is true
       - add_data_route.changed is true

tests/integration/targets/nd_compliance_analysis/tasks/main.yml

@@ -4,12 +4,12 @@
 # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - name: Test that we have an Nexus Dashboard Insights Group and Site Name defined
-  fail:
+  ansible.builtin.fail:
     msg: "Please define the following variables: insights_group, site_name."
   when: insights_group is not defined or site_name is not defined
 
 - name: Set vars
-  set_fact:
+  ansible.builtin.set_fact:
     ndi_info: &ndi_info
       insights_group: '{{ insights_group }}'
     ndi_site: &ndi_site
@@ -41,7 +41,7 @@
   register: query_existing
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_existing.current == []
 
@@ -133,4 +133,4 @@
 - name: Delete a compliance requirement
   cisco.nd.nd_compliance_requirement_config_manual:
     <<: *requirement_config_manual_bd
-    state: absent
+    state: absent

tests/integration/targets/nd_compliance_requirement_communication/tasks/main.yml

@@ -4,12 +4,12 @@
 # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - name: Test that we have an Nexus Dashboard Insights Group and Site Name defined
-  fail:
+  ansible.builtin.fail:
     msg: "Please define the following variables: insights_group, site_name."
   when: insights_group is not defined or site_name is not defined
 
 - name: Set vars
-  set_fact:
+  ansible.builtin.set_fact:
     ndi_info: &ndi_info
       insights_group: '{{ insights_group }}'
     ndi_base: &ndi_base
@@ -93,7 +93,7 @@
   register: query_existing
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_existing.current == []
 
@@ -127,7 +127,7 @@
   register: remove_requirement_may_traffic_restriction
 
 - name: Verify create compliance requirement ( type may / TRAFFIC_RESTRICTION )
-  assert:
+  ansible.builtin.assert:
     that:
       - cm_create_requirement_may_traffic_restriction.current.communicationType == "MAY"
       - cm_create_requirement_may_traffic_restriction.current.requirementType == "TRAFFIC_RESTRICTION"
@@ -251,7 +251,7 @@
   register: remove_requirement_must_not_traffic_restriction
 
 - name: Verify create compliance requirement ( type must_not / TRAFFIC_RESTRICTION )
-  assert:
+  ansible.builtin.assert:
     that:
       - create_requirement_must_not_traffic_restriction.current.communicationType == "MUST_NOT"
       - create_requirement_must_not_traffic_restriction.current.requirementType == "TRAFFIC_RESTRICTION"
@@ -272,7 +272,7 @@
   register: remove_requirement_must_not_segmentation
 
 - name: Verify create compliance requirement ( type must_not / SEGMENTATION )
-  assert:
+  ansible.builtin.assert:
     that:
       - create_requirement_must_not_segmentation.current.communicationType == "MUST_NOT"
       - create_requirement_must_not_segmentation.current.requirementType == "SEGMENTATION"
@@ -294,7 +294,7 @@
   register: remove_requirement_must_sla
 
 - name: Verify create compliance requirement ( type must / SLA )
-  assert:
+  ansible.builtin.assert:
     that:
       - create_requirement_must_sla.current.communicationType == "MUST"
       - create_requirement_must_sla.current.requirementType == "SLA"
@@ -345,7 +345,7 @@
   register: remove_requirement_description
 
 - name: Verify create compliance requirement ( with description )
-  assert:
+  ansible.builtin.assert:
     that:
       - create_requirement_description_none.current.description is not defined
       - create_requirement_description.current.description == "ansible-test-description"
@@ -416,7 +416,7 @@
   register: query_pattern_none_again
 
 - name: Verify create compliance requirement ( pattern == None )
-  assert:
+  ansible.builtin.assert:
     that:
       - query_pattern_none.current.objectSelectorA.includes.0.matches.0.vrfMatch.vrf.pattern == ""
       - query_pattern_value.current.objectSelectorA.includes.0.matches.0.vrfMatch.vrf.pattern == "value"
@@ -429,7 +429,7 @@
   register: remove_pattern_none
 
 - name: Verify delete non existing compliance requirement
-  assert:
+  ansible.builtin.assert:
     that:
       - remove_pattern_none.current == {}
 
@@ -512,7 +512,7 @@
   register: flags_not_set_to_ack
 
 - name: Verify create compliance with flags
-  assert:
+  ansible.builtin.assert:
     that:
       - reverse_port_true.current.complianceTrafficSelector.includes.selectors.0.selectors.0.reversePort == true
       - reverse_port_true.current.complianceTrafficSelector.includes.selectors.0.selectors.0.portSelectorAtoB.tcpFlagsNotSet == []
@@ -564,7 +564,7 @@
   register: query_existing
 
 - name: Verify 2 compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_existing.current | length == 2
 
@@ -582,7 +582,7 @@
   register: query_existing
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_existing.current == []
 
@@ -593,7 +593,7 @@
   register: query_non_existing
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_non_existing.current == {}
 
@@ -629,7 +629,7 @@
   register: requirement_change_end
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - cm_requirement_change_start is changed
     - nm_requirement_change_start is changed
@@ -652,7 +652,7 @@
   register: nm_remove_requirement_change
 
 - name: Verify no compliance requirement is removed
-  assert:
+  ansible.builtin.assert:
     that:
       - cm_remove_requirement_change.current == {}
       - nm_remove_requirement_change.current == {}
@@ -787,12 +787,12 @@
   register: flags_not_set_wrong_choice_error
 
 - name: Verify wrong choice error
-  assert:
+  ansible.builtin.assert:
     that:
       - 'type_wrong_choice_error.msg == "value of type must be one of: must, must_not, may, got: wrong_choice"'
       - 'object_type_wrong_choice_error.msg == "value of type must be one of: tenant, vrf, bd, epg, ap, l3out, l3instp, l2out, l2instp, filter, subject, contract, got: wrong_choice found in from_object -> includes"'
       - 'attribute_wrong_choice_error.msg == "value of attribute must be one of: DN, got: wrong_choice found in from_object -> includes"'
       - 'match_type_wrong_choice_error.msg == "value of type must be one of: tenant, vrf, bd, epg, ap, l3out, l3instp, l2out, l2instp, filter, subject, contract, got: wrong_choice found in from_object -> includes -> patterns"'
       - 'operator_type_wrong_choice_error.msg == "value of operator must be one of: contains, begins_with, ends_with, equal_to, not_equal_to, not_contains, not_begins_with, not_ends_with, got: wrong_choice found in from_object -> includes -> patterns"'
       - 'flags_set_wrong_choice_error.msg == "value of tcp_flags must be one or more of: ack, est, fin, res, syn. Got no match for: wrong_choice found in traffic_selector_rules -> from_object"'
-      - 'flags_not_set_wrong_choice_error.msg == "value of tcp_flags_not_set must be one or more of: ack, est, fin, res, syn. Got no match for: wrong_choice found in traffic_selector_rules -> from_object"'
+      - 'flags_not_set_wrong_choice_error.msg == "value of tcp_flags_not_set must be one or more of: ack, est, fin, res, syn. Got no match for: wrong_choice found in traffic_selector_rules -> from_object"'

tests/integration/targets/nd_compliance_requirement_config_import/tasks/main.yml

@@ -4,12 +4,12 @@
 # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - name: Test that we have an Nexus Dashboard Insights Group and Site Name defined
-  fail:
+  ansible.builtin.fail:
     msg: "Please define the following variables: insights_group, site_name."
   when: insights_group is not defined or site_name is not defined
 
 - name: Set vars
-  set_fact:
+  ansible.builtin.set_fact:
     ndi_info: &ndi_info
       insights_group: '{{ insights_group }}'
     ndi_base: &ndi_base
@@ -41,7 +41,7 @@
   register: query_existing
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_existing.current == []
 
@@ -88,7 +88,7 @@
   register: nm_remove_requirement
 
 - name: Verify create compliance requirement
-  assert:
+  ansible.builtin.assert:
     that:
       - cm_create_requirement.current.associatedSites | length == 1
       - cm_create_requirement.current.configurationType == "JSON_XML_BASED_CONFIGURATION_COMPLIANCE"
@@ -155,7 +155,7 @@
   register: remove_requirement_description
 
 - name: Verify create compliance requirement ( with description )
-  assert:
+  ansible.builtin.assert:
     that:
       - create_requirement_description_none.current.description is not defined
       - create_requirement_description.current.description == "ansible-test-description"
@@ -191,7 +191,7 @@
     state: absent
 
 - name: Verify incorrect file name and invalid file content error
-  assert:
+  ansible.builtin.assert:
     that:
       - err_change_requirement_file.msg == "The provided filename 'ansible-test-fail.json' is not matching the filename 'ansible-test.json' uploaded to the existing import configuration type compliance requirement"
       - 'err_create_requirement_incorrect_file.payload.messages.0.message == "The configuration file has invalid content. Found unexpected MO structure: {}"'

tests/integration/targets/nd_compliance_requirement_config_manual/tasks/main.yml

@@ -4,12 +4,12 @@
 # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - name: Test that we have an Nexus Dashboard Insights Group and Site Name defined
-  fail:
+  ansible.builtin.fail:
     msg: "Please define the following variables: insights_group, site_name."
   when: insights_group is not defined or site_name is not defined
 
 - name: Set vars
-  set_fact:
+  ansible.builtin.set_fact:
     ndi_info: &ndi_info
       insights_group: '{{ insights_group }}'
     ndi_base: &ndi_base
@@ -58,7 +58,7 @@
   register: query_existing
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_existing.current == []
 
@@ -107,7 +107,7 @@
   register: nm_remove_requirement
 
 - name: Verify create compliance requirement
-  assert:
+  ansible.builtin.assert:
     that:
       - cm_create_requirement.current.associatedSites | length == 1
       - cm_create_requirement.current.configComplianceParameter.andParameters.0.operator == "CONTAINS"
@@ -189,7 +189,7 @@
   register: remove_requirement_description
 
 - name: Verify create compliance requirement ( with description )
-  assert:
+  ansible.builtin.assert:
     that:
       - create_requirement_description_none.current.description is not defined
       - create_requirement_description.current.description == "ansible-test-description"

tests/integration/targets/nd_compliance_requirement_config_snapshot/tasks/main.yml

@@ -4,12 +4,12 @@
 # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
 
 - name: Test that we have an Nexus Dashboard Insights Group and Site Name defined
-  fail:
+  ansible.builtin.fail:
     msg: "Please define the following variables: insights_group, site_name."
   when: insights_group is not defined or site_name is not defined
 
 - name: Set vars
-  set_fact:
+  ansible.builtin.set_fact:
     ndi_info: &ndi_info
       insights_group: '{{ insights_group }}'
     ndi_site: &ndi_site
@@ -43,7 +43,7 @@
   register: query_existing
 
 - name: Verify no compliance requirements are present
-  assert:
+  ansible.builtin.assert:
     that:
     - query_existing.current == []
 
@@ -90,7 +90,7 @@
   register: nm_remove_requirement
 
 - name: Verify create compliance requirement
-  assert:
+  ansible.builtin.assert:
     that:
       - cm_create_requirement.current.associatedSites | length == 1
       - cm_create_requirement.current.baseEpochId is defined
@@ -132,7 +132,7 @@
   register: nm_remove_requirement_epoch_id
 
 - name: Verify create compliance requirement
-  assert:
+  ansible.builtin.assert:
     that:
       - nm_remove_requirement_epoch_id.current == {}
       - nm_create_requirement_epoch_id.current.baseEpochId == "{{ period_latest.current.epochId }}"
@@ -179,7 +179,7 @@
   register: remove_requirement_description
 
 - name: Verify create compliance requirement ( descriptions )
-  assert:
+  ansible.builtin.assert:
     that:
       - create_requirement_description_none.current.description is not defined
       - create_requirement_description.current.description == "ansible-test-description"
@@ -197,6 +197,6 @@
   register: err_create_requirement_epoch_id_invalid
 
 - name: Verify invalid epoch id
-  assert:
+  ansible.builtin.assert:
     that:
       - err_create_requirement_epoch_id_invalid.payload.messages.0.message == "The epoch with id invalid is not valid."