Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bugs #113 and #115 #129

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Resolve bugs #113 and #115 #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2bb9c36
Resolve issues #115
seconroy Dec 4, 2023
73c5096
Resolve issues #113
seconroy Dec 4, 2023
de31b61
Update changelog
seconroy Dec 4, 2023
9031474
Update version name
seconroy Dec 11, 2023
6dbeea8
Update centralized_policy.yaml
danischm Dec 19, 2023
9dec390
Update centralized_policy.yaml
danischm Dec 19, 2023
b6f7a7a
Update centralized_policy.yaml
danischm Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
- Add `sdwan_system_aaa_profile_parcel` resource and data source
- Add `sdwan_system_banner_profile_parcel` resource and data source
- Add `sdwan_system_bfd_profile_parcel` resource and data source
- Fix issue with `sdwan_centralized_policy` not accepting all valid parameters
- Fix issue with `sdwan_custom_control_topology_policy_definition` not accepting all possible values

## 0.2.11

Expand Down
3 changes: 3 additions & 0 deletions docs/data-sources/centralized_policy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ Read-Only:
Read-Only:

- `direction` (String) Direction
- `region_ids` (List of String) List of region IDs
- `region_list_ids` (List of String) List of region list IDs
- `region_list_versions` (List of String) List of region list versions
- `site_list_ids` (List of String) List of site list IDs
- `site_list_versions` (List of String) List of site list versions
- `vpn_list_ids` (List of String) List of VPN list IDs
Expand Down
2 changes: 2 additions & 0 deletions docs/guides/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ description: |-
- Add `sdwan_system_aaa_profile_parcel` resource and data source
- Add `sdwan_system_banner_profile_parcel` resource and data source
- Add `sdwan_system_bfd_profile_parcel` resource and data source
- Fix issue with `sdwan_centralized_policy` not accepting all valid parameters
- Fix issue with `sdwan_custom_control_topology_policy_definition` not accepting all possible values

## 0.2.11

Expand Down
10 changes: 5 additions & 5 deletions docs/resources/centralized_policy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@ Optional:
<a id="nestedatt--definitions--entries"></a>
### Nested Schema for `definitions.entries`

Required:

- `site_list_ids` (List of String) List of site list IDs

Optional:

- `direction` (String) Direction
- Choices: `service`, `tunnel`, `all`
- Choices: `service`, `tunnel`, `all`, `in`, `out`
- `region_ids` (List of String) List of region IDs
- `region_list_ids` (List of String) List of region list IDs
- `region_list_versions` (List of String) List of region list versions
- `site_list_ids` (List of String) List of site list IDs
- `site_list_versions` (List of String) List of site list versions
- `vpn_list_ids` (List of String) List of VPN list IDs
- `vpn_list_versions` (List of String) List of VPN list versions
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/custom_control_topology_policy_definition.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ Optional:
- `omp_tag` (Number) OMP tag
- Range: `0`-`4294967295`
- `origin` (String) Origin
- Choices: `igp`, `egp`, `incomplete`
- Choices: `igp`, `egp`, `incomplete`, `aggregrate`, `bgp`, `bgp-external`, `bgp-internal`, `connected`, `eigrp`, `ospf`, `ospf-inter-area`, `ospf-intra-area`, `ospf-external1`, `ospf-external2`, `rip`, `static`, `eigrp-summary`, `eigrp-internal`, `eigrp-external`, `lisp`, `nat-dia`, `natpool`, `isis`, `isis-level1`, `isis-level2`
- `originator` (String) Originator IP
- `path_type` (String) Path type
- Choices: `hierarchical-path`, `direct-path`, `transport-gateway-path`
Expand Down
25 changes: 22 additions & 3 deletions gen/definitions/generic/centralized_policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ attributes:
tf_name: site_list_ids
type: StringList
id: true
mandatory: true
description: List of site list IDs
example: 2081c2f4-3f9f-4fee-8078-dcc8904e368d
test_value: "[sdwan_site_list_policy_object.sites1.id]"
Expand All @@ -77,6 +76,7 @@ attributes:
- model_name: vpnLists
tf_name: vpn_list_ids
type: StringList
id: true
description: List of VPN list IDs
example: 7d0c2444-8743-4414-add0-866945ea9f70
test_value: "[sdwan_vpn_list_policy_object.vpns1.id]"
Expand All @@ -88,9 +88,28 @@ attributes:
- model_name: direction
tf_name: direction
type: String
enum_values: [service, tunnel, all]
enum_values: [in, out]
description: Direction
example: service
example: in
- model_name: regionLists
tf_name: region_list_ids
type: StringList
id: true
description: List of region list IDs
example: 2081c2f4-3f9f-4fee-8078-dcc8904e368d
exclude_test: true
- tf_name: region_list_versions
tf_only: true
type: Versions
description: List of region list versions
exclude_test: true
- model_name: regionIds
tf_name: region_ids
type: StringList
id: true
description: List of region IDs
example: 1
exclude_test: true

test_prerequisites: |
resource "sdwan_site_list_policy_object" "sites1" {
Expand Down
29 changes: 28 additions & 1 deletion gen/definitions/generic/custom_control_topology_policy_definition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,34 @@ attributes:
name: type
value: origin
type: String
enum_values: [igp, egp, incomplete]
enum_values:
[
igp,
egp,
incomplete,
aggregrate,
bgp,
bgp-external,
bgp-internal,
connected,
eigrp,
ospf,
ospf-inter-area,
ospf-intra-area,
ospf-external1,
ospf-external2,
rip,
static,
eigrp-summary,
eigrp-internal,
eigrp-external,
lisp,
nat-dia,
natpool,
isis,
isis-level1,
isis-level2,
]
description: Origin
example: igp
exclude_test: true
Expand Down
15 changes: 15 additions & 0 deletions internal/provider/data_source_sdwan_centralized_policy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 41 additions & 7 deletions internal/provider/model_sdwan_centralized_policy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 18 additions & 3 deletions internal/provider/resource_sdwan_centralized_policy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions internal/provider/resource_sdwan_custom_control_topology_policy_definition.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions templates/guides/changelog.md.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ description: |-
- Add `sdwan_system_aaa_profile_parcel` resource and data source
- Add `sdwan_system_banner_profile_parcel` resource and data source
- Add `sdwan_system_bfd_profile_parcel` resource and data source
- Fix issue with `sdwan_centralized_policy` not accepting all valid parameters
- Fix issue with `sdwan_custom_control_topology_policy_definition` not accepting all possible values

## 0.2.11

Expand Down