-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new model of NT handgun. #6829
Open
AlphaM01
wants to merge
21
commits into
Citadel-Station-13:master
Choose a base branch
from
AlphaM01:nt-handgun
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+253
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax59 & ax99 no holster yet
github-actions
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Merge Conflict
labels
Oct 30, 2024
AlphaM01
changed the title
[WIP] Adds a new model of NT handgun.
Adds a new model of NT handgun.
Nov 11, 2024
TheLordME
approved these changes
Nov 12, 2024
silicons
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a new handgun platform known as AXHS, it comes in two models:
AX59 is a .45 ACP semi-automatic pistol which loads 12-round double-stack magazines. It comes with a built in light and lanyard loop (see #6826 for gun attachment code, which this will rely on). It is issued to Exploration through a dedicated gun case in the points vendor for 250 points.
AX99 is a .44 Magnum semi-automatic pistol which loads 7-round single-stack magazines. It has no attachments. Per fluff it is the PMD's less gimmicky service weapon alongside the very confusingly named Service Weapon.
This PR also makes the base a45 magazine unused. M1911-based platforms now load a45/singlestack magazines and all other 45 pistols now load a45/doublestack magazines, therefore, every code mention of the base .45 magazine have been changed to one of them (or both in the case of random drops).
Capacity on 9mm pistol magazines has been bumped up to 15 base and 21 extended after discussion with dev chat.
Why It's Good For The Game
Exploration may or may not move away from the infinitely rechargeable phasers at some point, this is just a means to give players an opt-in alternative.
Just giving them a pistol felt cheap though, so I wanted to provide something designed for the department with QoL which are primarily the attachments.
Changelog
🆑
add: Added two new pistols "AX59" and "AX99".
add: Added AXHS Gun Case to the exploration points vendor.
add: Added a new morale poster.
tweak: .45 magazines now split into double-stack (12rnd) and single-stack (7rnd).
tweak: 9mm pistol magazines now hold 15 rounds (normal) and 21 rounds (extended)
/:cl: