[s] update the thing #6846
Open
[s] update the thing #6846
+74
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
github-actions
bot
added
size/L
silicons
pushed a commit
that referenced
this pull request
Nov 12, 2024
silicons
reviewed
Nov 14, 2024
Comment on lines
+15
to
+42
| if(byond_version >= 512) | ||
| if (!byond_build || byond_build < 1386) | ||
| message_admins(SPAN_ADMINNOTICE("[key_name(src)] has been detected as spoofing their byond version. Connection rejected.")) | ||
| add_system_note("Spoofed-Byond-Version", "Detected as using a spoofed byond version.") | ||
| log_suspicious_login("Failed Login: [key] - Spoofed byond version") | ||
| qdel(src) | ||
| return FALSE | ||
| if (num2text(byond_build) in GLOB.blacklisted_builds) | ||
| to_chat_immediate(src, SPAN_USERDANGER("Your version of byond is blacklisted.")) | ||
| to_chat_immediate(src, SPAN_DANGER("Byond build [byond_build] ([byond_version].[byond_build]) has been blacklisted for the following reason: [GLOB.blacklisted_builds[num2text(byond_build)]].")) | ||
| to_chat_immediate(src, SPAN_DANGER("Please download a new version of byond. If [byond_build] is the latest, you can go to <a href=\"https://secure.byond.com/download/build\">BYOND's website</a> to download other versions.")) | ||
| if(is_staff()) | ||
| to_chat_immediate(src, "As an admin, you are being allowed to continue using this version, but please consider changing byond versions") | ||
| else | ||
| qdel(src) | ||
| return FALSE | ||
|
|
||
| var/breaking_version = CONFIG_GET(number/client_error_version) | ||
| var/breaking_build = CONFIG_GET(number/client_error_build) | ||
| var/warn_version = CONFIG_GET(number/client_warn_version) | ||
| var/warn_build = CONFIG_GET(number/client_warn_build) | ||
|
|
||
| if (byond_version < breaking_version || (byond_version == breaking_version && byond_build < breaking_build)) //Out of date client. | ||
| to_chat_immediate(src, SPAN_DANGER("<b>Your version of BYOND is too old:</b>")) | ||
| to_chat_immediate(src, CONFIG_GET(string/client_error_message)) | ||
| to_chat_immediate(src, "Your version: [byond_version].[byond_build]") | ||
| to_chat_immediate(src, "Required version: [breaking_version].[breaking_build] or later") | ||
| to_chat_immediate(src, "Visit <a href=\"https://secure.byond.com/download\">BYOND's website</a> to get the latest version of BYOND.") |
There was a problem hiding this comment.
other than the spoofing, is there a reason this is not using security procs / browse()?
it's not a critical security issue for someone to have wallhacks for a second before they're booted and logged
our old chat looks like absolute ass and it's a big UI/UX issue to have people be DC'd and forced to eyestrain to see why
also, all of these should log somewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.