-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TAN-3608] Support Matrix question in form builder #10127
base: master
Are you sure you want to change the base?
Conversation
|
…bDotCo/citizenlab into TAN-3608-matrix-q-form-builder
reset(defaultValues); | ||
} | ||
}, [defaultValues, reset]); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue we discussed actually wasn't solved by the BE in the end, so I revisited it again.
I've spent almost 2 full days on this now, and this is the only thing I've come up with which solves the issue. It causes a single extra re-render when the form is loaded if there are matrix questions, but otherwise I don't think it causes too much of a problem.
I'd still like to try and dig deeper into this issue to get it properly solved, but I'm thinking maybe for now to leave this in so I can finish up the other back office things (survey results, sense-making, etc.) and then re-visit this again next week? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luucvanderzee That's correct! This PR is just for support in the back office/form builder. I have another PR for the front office to make PRs smaller & code reviewing simpler :) |
Supports the new matrix question type in the back office form builder.
@luucvanderzee you only need to review the FE code in this PR :)