Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAN-3608] Support Matrix question in form builder #10127

Open
wants to merge 60 commits into
base: master
Choose a base branch
from

Conversation

amanda-anderson
Copy link
Contributor

@amanda-anderson amanda-anderson commented Jan 21, 2025

Supports the new matrix question type in the back office form builder.

@luucvanderzee you only need to review the FE code in this PR :)

Copy link

@amanda-anderson amanda-anderson changed the base branch from master to fe-ranking-survey-question-feature January 21, 2025 14:42
@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Jan 21, 2025

Warnings
⚠️

The changelog is empty. What should I put in the changelog?

Messages
📖 Notion issue: TAN-3608
📖

Run the e2e tests

📖 Check translation progress

Generated by 🚫 dangerJS against 2b7e518

@amanda-anderson amanda-anderson changed the title [TAN-3608] Support Matrix question in form builder [TAN-3608] WIP Support Matrix question in form builder Jan 23, 2025
reset(defaultValues);
}
}, [defaultValues, reset]);

Copy link
Contributor Author

@amanda-anderson amanda-anderson Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the issue we discussed actually wasn't solved by the BE in the end, so I revisited it again.

I've spent almost 2 full days on this now, and this is the only thing I've come up with which solves the issue. It causes a single extra re-render when the form is loaded if there are matrix questions, but otherwise I don't think it causes too much of a problem.

I'd still like to try and dig deeper into this issue to get it properly solved, but I'm thinking maybe for now to leave this in so I can finish up the other back office things (survey results, sense-making, etc.) and then re-visit this again next week? 🤔

@amanda-anderson amanda-anderson changed the title [TAN-3608] WIP Support Matrix question in form builder [TAN-3608] Support Matrix question in form builder Jan 24, 2025
Copy link
Contributor

@luucvanderzee luucvanderzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm misunderstanding something but I can't seem to get the matrix question to work... I added two statements, but it seems to just render like a normal (singular) linear scale? Also the settings only show 5 labels but the linear scale has 7

Screenshot 2025-01-24 at 14 38 35 Screenshot 2025-01-24 at 14 38 43

@amanda-anderson
Copy link
Contributor Author

I can't seem to get the matrix question to work

@luucvanderzee That's correct! This PR is just for support in the back office/form builder. I have another PR for the front office to make PRs smaller & code reviewing simpler :)

@amanda-anderson amanda-anderson changed the base branch from fe-ranking-survey-question-feature to master January 27, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants