Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #983 from CitrineInformatics/feature/pne-6… #985

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

anoto-moniz
Copy link
Collaborator

…511-shapley-generation"

This reverts commit d4a2e39, reversing changes made to 556ce5f.

Note: there was a small bug fix in this PR to correct handling Shapley payloads when one is already generating. That was retained.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

…511-shapley-generation"

This reverts commit d4a2e39, reversing
changes made to 556ce5f.
@anoto-moniz anoto-moniz marked this pull request as ready for review January 16, 2025 15:48
@anoto-moniz anoto-moniz requested a review from a team as a code owner January 16, 2025 15:48
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad. LGTM.

@anoto-moniz anoto-moniz merged commit 7eac254 into main Jan 16, 2025
17 checks passed
@anoto-moniz anoto-moniz deleted the revert-shapley-generate branch January 16, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants