Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-4 Add media feature #1

Merged
merged 2 commits into from
Nov 20, 2020
Merged

UHF-4 Add media feature #1

merged 2 commits into from
Nov 20, 2020

Conversation

teroelonen
Copy link
Contributor

How to test (if you have no setup etc.):

  1. Clone hel.fi environment (https://github.com/City-of-Helsinki/drupal-helfi) and run make new
  2. After the installation go to UHF-4: UHF-4 Media feature drupal-helfi#14 and follow the instructions there.

khalima
khalima requested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ./config/install/langauge -folder has a typo. Should be language

khalima
khalima approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purrrfect!

@teroelonen teroelonen merged commit 7e97983 into 1.x Nov 20, 2020
@teroelonen teroelonen deleted the UHF-4-media-configuration branch November 20, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima