Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase helsinki azure AD group listing size #309

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

voneiden
Copy link
Contributor

Microsoft Graph memberOf API defaults to page size of 100. Increase it to 999 like it is in helsinki-tunnistus-plugin as we have users who have 100+ groups.

Refs: HP-2432

@voneiden voneiden requested a review from a team May 13, 2024 12:33
Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 :shipit:

Microsoft Graph memberOf API defaults to page size of 100. Increase it
to 999 like it is in helsinki-tunnistus-plugin as we have users who have
100+ groups.

Refs: HP-2432
@voneiden voneiden merged commit a594c7c into develop May 13, 2024
3 of 4 checks passed
@voneiden voneiden deleted the fix-groups branch May 13, 2024 12:43
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants