Fix in-page link without target (#112)

* Move participation page connect twitter and connect facebook menuitem roles from links to list items * Use button elements for twitterConnectBtn and fbConnectBtn to align with their ids
CivicTechTO · Feb 3, 2025 · ea1b5cf · ea1b5cf
1 parent 717acaa
commit ea1b5cf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/client-participation/js/templates/conversationTabs.handlebars b/client-participation/js/templates/conversationTabs.handlebars
@@ -154,10 +154,10 @@
 
 {{!-- {{#ifAuthenticated}} --}}
   {{#unless hasTwitter}}
-    <li role="presentation"><a id="twitterConnectBtn" role="menuitem" href="#"><div style="display: inline-block; width: 20px"><i class="fa fa-twitter"></i></div>Connect Twitter</a></li>
+    <li role="presentation"><button id="twitterConnectBtn" role="menuitem"><div style="display: inline-block; width: 20px"><i class="fa fa-twitter"></i></div>Connect Twitter</button></li>
   {{/unless}}
   {{#unless hasFacebook}}
-    <li role="presentation"><a id="fbConnectBtn" role="menuitem" href="#"><div style="display: inline-block; width: 20px"><i class="fa fa-facebook"></i></div>Connect Facebook</a></li>
+    <li role="presentation"><button id="fbConnectBtn" role="menuitem"><div style="display: inline-block; width: 20px"><i class="fa fa-facebook"></i></div>Connect Facebook</button></li>
   {{/unless}}
     {{!-- <li role="presentation"><a role="menuitem" href="#"><div style="display: inline-block; width: 20px"><img src="https://pol.is/polis-favicon_favicon.png" height="16px" id="opinion_groups_logo"/></div> Polis</a></li> --}}