boot-qemu.py: Allow memory value to be customized #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default memory value for most machines is 512 MB, which is generally sufficient for most use cases, as these machines are usually quick to start up and shutdown. Unfortunately, there are times where the machine may run out of memory when percpu memory allocations are involved along with a large number of cores, which can happen when booting under KVM due to the script's heuristics for selecting a good default for '-smp', which depends on the number of cores on the host machine. Rather than try to adjust the existing heuristics further, allow users to specify a memory value that may be better suited for their machine, just like '-smp'. Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default memory value for most machines is 512 MB, which is generally sufficient for most use cases, as these machines are usually quick to start up and shutdown. Unfortunately, there are times where the machine may run out of memory when percpu memory allocations are involved along with a large number of cores, which can happen when booting under KVM due to the script's heuristics for selecting a good default for
-smp, which depends on the number of cores on the host machine.Rather than try to adjust the existing heuristics further, allow users to specify a memory value that may be better suited for their machine, just like
-smp.