[EAGLE-3887] model uploadv2 cli #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackizilkale
reviewed
Jan 22, 2024
ackizilkale
reviewed
Jan 22, 2024
ackizilkale
reviewed
Jan 22, 2024
| "--infer-param", | ||
| required=False, | ||
| default="", | ||
| help="Path to json file contains inference parameters") |
There was a problem hiding this comment.
are we going to use json or yaml?
There was a problem hiding this comment.
oh this one is json I guess.
There was a problem hiding this comment.
We'll use .yaml, but this one is for inference_paramters used when user input args one by one (like previous). User also can use only .yaml with all args provided in it.
ackizilkale
reviewed
Jan 22, 2024
ackizilkale
reviewed
Jan 22, 2024
ackizilkale
approved these changes
Jan 22, 2024
Merged
phatvo9
added a commit
that referenced
this pull request
Feb 7, 2024
* [EAGLE-3887] model uploadv2 cli (#269) * update upload/init cli * add login,example + update create * implement upload cli * minor fix: download when list example * update help of login * force to test before uploading * upload cli: upload -> upload model * add info after model created * addressed comments --------- Co-authored-by: phtvo <[email protected]> * [EAGLE-3915]- refactor model uploadv2 repository (#276) * refactor inference.py + config * add init repo * fix init repo * update type check msg * fix triton list input + load user cfg * resolve merge * update init cli * format triton output cfg, add build module, build repo * fix missing model.py * always check image_shape * Update triton_config docstring * exclude pycache * typos * check in and out len * check all cfg before gen files * fix docstring * fix typos --------- Co-authored-by: phtvo <[email protected]> * fix typos * [EAGLE-3916] build cli (#278) * add build cli * checking clarifai config * add desc attr * update upload cli * typos * rm unused * check in and out len * check all cfg before gen files * fix docstring * fix typos * typo --------- Co-authored-by: phtvo <[email protected]> * [EAGLE-3917] - model uploadv2 user test (#279) * add default tests + fix parse user cfg * force using np in output * fix input type of multimodal emb * fix default test for multimodal * fix parse local cfg * enable test when building * typo --------- Co-authored-by: phtvo <[email protected]> * [EAGLE-3918]-module tests (#285) * update tests + fix import inference in test * typos * not set image_shape for non-image input * module tests * constant for tensor names * correct type,value of infer params --------- Co-authored-by: phtvo <[email protected]> * fix upload * disallow using test_path * postprocess det * fix load examples * rm unused args * ensure using list or tuple for labels * fix force download example * [EAGLE-3932] model uploadv2 doc (#287) * update doc * minor update * update rm unused upload args --------- Co-authored-by: phtvo <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New cli interface
Usage:
NOTE: if
working-direxists, need to set--overwriteflag otherwise an error arises3. See available examples
By default It will run test before uploading, looking for test.py in current directory or you can specify the test file with
test-patharg. To upload without test, setno-testflag.upload without config file
upload with config file (WIP)