Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EAGLE-5416] Added Tests for Download checkpoints and Fix download methods #488

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

zeiler
Copy link
Member

@zeiler zeiler commented Jan 17, 2025

  • Added download checkpoints tests without setting PAT
  • remove .cache directory while downloading checkpoints
  • Fixed validate_download method: it got broke before because of adding ignore_patterns while downloading checkpoints.
  • Handle . as model_path better
  • Do less validation if just calling download_checkpoints.
  • Fall back to env var HF_TOKEN if not provided in the checkpoints section of config.yaml

@zeiler zeiler requested a review from ackizilkale January 17, 2025 17:17
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Copy link

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 65%
clarifai.client 71%
clarifai.client.auth 74%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 9%
clarifai.runners.models 27%
clarifai.runners.utils 66%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 77%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 64% (4130 / 6492)

Minimum allowed line rate is 50%

@zeiler zeiler enabled auto-merge (squash) January 17, 2025 17:29
@zeiler zeiler merged commit 540c0eb into master Jan 17, 2025
17 checks passed
@zeiler zeiler deleted the revert-487-revert-484-download_checkpoints-tests branch January 17, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants