Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EAGLE-5342] Added Tests for Model run locally #492

Merged
merged 12 commits into from
Jan 24, 2025
Merged

Conversation

luv-bansal
Copy link
Contributor

@luv-bansal luv-bansal commented Jan 22, 2025

What

  • Added tests for Model run locally within both virtual env and docker container
  • Tests covers all the related function used in following command:
    • clarifai model test-locally --model_path <> --model env
    • clarifai model test-locally --model_path <> --model container
  • I also fixed some edge cases for the test-locally and run-locally commands to ensure they work across all operating systems, and also works whether or not the user's system has a GPU.

Why

How

Tests

Notes

@luv-bansal luv-bansal changed the title Added Model run locally tests [EAGLE-5342] Added Model run locally tests Jan 23, 2025
@luv-bansal luv-bansal requested a review from zeiler January 23, 2025 10:16
@luv-bansal luv-bansal changed the title [EAGLE-5342] Added Model run locally tests [EAGLE-5342] Added Tests for Model run locally Jan 23, 2025
Copy link
Member

@zeiler zeiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, good improvements. Just that one arg should change or you can do that in a follow PR and make sure all places are changed.

clarifai/runners/models/model_run_locally.py Outdated Show resolved Hide resolved
@luv-bansal luv-bansal enabled auto-merge (squash) January 24, 2025 06:38
Copy link

Code Coverage

Package Line Rate Health
clarifai 43%
clarifai.cli 65%
clarifai.client 71%
clarifai.client.auth 74%
clarifai.constants 100%
clarifai.datasets 100%
clarifai.datasets.export 80%
clarifai.datasets.upload 75%
clarifai.datasets.upload.loaders 37%
clarifai.models 100%
clarifai.modules 0%
clarifai.rag 72%
clarifai.runners 9%
clarifai.runners.models 39%
clarifai.runners.utils 66%
clarifai.schema 100%
clarifai.urls 80%
clarifai.utils 77%
clarifai.utils.evaluation 67%
clarifai.workflows 94%
Summary 65% (4241 / 6514)

Minimum allowed line rate is 50%

@luv-bansal luv-bansal merged commit 4a7a506 into master Jan 24, 2025
17 checks passed
@luv-bansal luv-bansal deleted the model-upload-tests branch January 24, 2025 06:55
@luv-bansal luv-bansal mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants