Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-876]: Fixed Issue with Filename as Invalid Input ID #501

Merged
merged 3 commits into from
Jan 31, 2025
Merged

[DEVX-876]: Fixed Issue with Filename as Invalid Input ID #501

merged 3 commits into from
Jan 31, 2025

Conversation

srikanthbachala20
Copy link
Contributor

Why

How

  • Added a function to clean invalid Input IDs before pushing them

mogith-pn
mogith-pn requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@mogith-pn mogith-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some comments. Please take a look into it.

clarifai/utils/misc.py Outdated Show resolved Hide resolved
clarifai/utils/misc.py Outdated Show resolved Hide resolved
mogith-pn
mogith-pn approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@mogith-pn mogith-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM

@srikanthbachala20
[WFP-902]: Fixed Deployment Tests (#502)
fda7b0b 
* [WFP-902]: Fixed Deployment Tests

* [WFP-902]: Fixed Deployment Tests
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
clarifai 43% ❌
clarifai.cli 64% ➖
clarifai.client 71% ➖
clarifai.client.auth 74% ➖
clarifai.constants 100% ✔
clarifai.datasets 100% ✔
clarifai.datasets.export 80% ✔
clarifai.datasets.upload 75% ➖
clarifai.datasets.upload.loaders 37% ❌
clarifai.models 100% ✔
clarifai.modules 0% ❌
clarifai.rag 72% ➖
clarifai.runners 9% ❌
clarifai.runners.models 56% ➖
clarifai.runners.utils 65% ➖
clarifai.schema 100% ✔
clarifai.urls 80% ✔
clarifai.utils 77% ➖
clarifai.utils.evaluation 67% ➖
clarifai.workflows 94% ✔
Summary 67% (4413 / 6545) ➖

Minimum allowed line rate is 50%

@srikanthbachala20 srikanthbachala20 merged commit 9e024de into master Jan 31, 2025
17 checks passed
@srikanthbachala20 srikanthbachala20 deleted the DEVX-876-Fix-Issue-with-Invalid-Input-ID branch January 31, 2025 09:32
@luv-bansal luv-bansal mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitinbhojwani nitinbhojwani nitinbhojwani approved these changes

@mogith-pn mogith-pn mogith-pn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikanthbachala20 @nitinbhojwani @mogith-pn