Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PREVIEW] Show the possibly listening process in the AlreadyRunning exception message #158

Closed
wants to merge 1 commit into from

Conversation

mmaslowskicc
Copy link
Contributor

refs #133

What I think must be changed before it's mergable:

  • we should not have the same AlreadyRunning in Executor (which is used also for PIDExecutor and could be used e.g. for Unix socket executors; these don't have port numbers): we could instead subclass it to add the port number and the new message in an exception specific to the TCPExecutor
  • we should find the responsible process in the TCPExecutor, not the exception class
  • since there are potential race conditions (e.g. a listening process exists between us checking if the port is available and reporting the exception message), we might want to retry the check in some cases

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 90.173% when pulling a3f896f on mmaslowskicc:issues-133 into d86169d on ClearcodeHQ:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 90.173% when pulling a3f896f on mmaslowskicc:issues-133 into d86169d on ClearcodeHQ:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 90.173% when pulling a3f896f on mmaslowskicc:issues-133 into d86169d on ClearcodeHQ:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 90.173% when pulling a3f896f on mmaslowskicc:issues-133 into d86169d on ClearcodeHQ:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 90.173% when pulling a3f896f on mmaslowskicc:issues-133 into d86169d on ClearcodeHQ:master.

@mmaslowskicc
Copy link
Contributor Author

Tests show also that this must be an optional feature, since psutil is not available on at least PyPy3.

@fizyk fizyk force-pushed the master branch 4 times, most recently from 1881a73 to d040e1e Compare July 2, 2018 11:35
@fizyk fizyk closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants