Hd staff mentions #17
Conversation
…pdesk for Colorado
| formatted_mention = f'<span style="color:blue">@{user.first_name} {user.last_name}</span>' | ||
|
|
||
| return formatted_mention | ||
| except User.DoesNotExist: |
There was a problem hiding this comment.
It's possible for two users to have the same first and last name, so I would also catch User.MultipleObjectsReturned as well as User.DoesNotExist
helpdesk/views/staff.py
Outdated
| mention_pattern = re.compile(r'@\"(.*?)\"') | ||
|
|
||
| for match in mention_pattern.findall(comment): | ||
| first_name, last_name = match.split() |
There was a problem hiding this comment.
Add the code where you check for the email address as well as the first name / last name
helpdesk/views/staff.py
Outdated
| user=user, | ||
| ticket=ticket, | ||
| organization=ticket.ticket_form.organization, | ||
| message = "You have been mentioned in ticket " + str(ticket.id), |
There was a problem hiding this comment.
Could you change the message to "<request user's name/email> mentioned you on ticket <ticket id>"?
helpdesk/views/staff.py
Outdated
|
|
||
| mention_pattern = re.compile(r'@\"(.*?)\"') | ||
|
|
||
| for match in mention_pattern.findall(comment): |
There was a problem hiding this comment.
Only staff users are allowed to use Markdown, so check that request.user is HD staff first
helpdesk/views/staff.py
Outdated
|
|
||
| for match in mention_pattern.findall(comment): | ||
| first_name, last_name = match.split() | ||
| user = User.objects.get(first_name=first_name, last_name=last_name) |
There was a problem hiding this comment.
Staff shouldn't be able to @ users who aren't staff, so after finding user, check that it's staff
|
|
||
| try: | ||
| if '@' in mention: | ||
| user = User.objects.get(email=mention) |
There was a problem hiding this comment.
Staff shouldn't be able to @ users who aren't staff, so after finding user, check that it's staff
Adds ability for Helpdesk Users to @ other Helpdesk Users in followup comments